You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Andrew MacBean (Created) (JIRA)" <ji...@apache.org> on 2012/02/08 12:10:57 UTC

[jira] [Created] (QPID-3821) Uncaught exception thrown in QueueRunner.run() could cause QueueRunner to remain stuck in RUNNING state permanently

Uncaught exception thrown in QueueRunner.run() could cause QueueRunner to remain stuck in RUNNING state permanently
-------------------------------------------------------------------------------------------------------------------

                 Key: QPID-3821
                 URL: https://issues.apache.org/jira/browse/QPID-3821
             Project: Qpid
          Issue Type: Bug
          Components: Java Broker
    Affects Versions: 0.15
            Reporter: Andrew MacBean
            Assignee: Andrew MacBean
             Fix For: 0.15


The QueueRunner.run() method calls SimpleAMQQueue.processQueue(...) method within a try/catch block.  If this threw an exception that was not caught then the state of the QueueRunner is never set back to IDLE or SCHEDULED.

The code at the end of the method should be moved into the finally block to prevent this from happening.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Resolved] (QPID-3821) Uncaught exception thrown in QueueRunner and SubFlushRunner run() could cause them to remain stuck in RUNNING state permanently

Posted by "Keith Wall (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall resolved QPID-3821.
------------------------------

    Resolution: Fixed

No comments from me, patch applied.
                
> Uncaught exception thrown in QueueRunner and SubFlushRunner run() could cause them to remain stuck in RUNNING state permanently
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3821
>                 URL: https://issues.apache.org/jira/browse/QPID-3821
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.15
>            Reporter: Andrew MacBean
>            Assignee: Keith Wall
>             Fix For: 0.15
>
>         Attachments: 0001-QPID-3821-Uncaught-exception-thrown-in-QueueRunner.r.patch
>
>
> The QueueRunner.run() method calls SimpleAMQQueue.processQueue(...) method within a try/catch block.  If this threw an exception that was not caught then the state of the QueueRunner is never set back to IDLE or SCHEDULED.
> The same pattern is present in the SubFlushRunner.run().
> The code at the end of the method should be moved into the finally block to prevent this from happening.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Commented] (QPID-3821) Uncaught exception thrown in QueueRunner and SubFlushRunner run() could cause them to remain stuck in RUNNING state permanently

Posted by "Andrew MacBean (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204444#comment-13204444 ] 

Andrew MacBean commented on QPID-3821:
--------------------------------------

Patch modified to include SubFlushRunner.
                
> Uncaught exception thrown in QueueRunner and SubFlushRunner run() could cause them to remain stuck in RUNNING state permanently
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3821
>                 URL: https://issues.apache.org/jira/browse/QPID-3821
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.15
>            Reporter: Andrew MacBean
>            Assignee: Keith Wall
>             Fix For: 0.15
>
>         Attachments: 0001-QPID-3821-Uncaught-exception-thrown-in-QueueRunner.r.patch
>
>
> The QueueRunner.run() method calls SimpleAMQQueue.processQueue(...) method within a try/catch block.  If this threw an exception that was not caught then the state of the QueueRunner is never set back to IDLE or SCHEDULED.
> The same pattern is present in the SubFlushRunner.run().
> The code at the end of the method should be moved into the finally block to prevent this from happening.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3821) Uncaught exception thrown in QueueRunner.run() could cause QueueRunner to remain stuck in RUNNING state permanently

Posted by "Andrew MacBean (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew MacBean updated QPID-3821:
---------------------------------

    Status: Ready To Review  (was: In Progress)
    
> Uncaught exception thrown in QueueRunner.run() could cause QueueRunner to remain stuck in RUNNING state permanently
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3821
>                 URL: https://issues.apache.org/jira/browse/QPID-3821
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.15
>            Reporter: Andrew MacBean
>            Assignee: Andrew MacBean
>             Fix For: 0.15
>
>         Attachments: 0001-QPID-3821-Uncaught-exception-thrown-in-QueueRunner.r.patch
>
>
> The QueueRunner.run() method calls SimpleAMQQueue.processQueue(...) method within a try/catch block.  If this threw an exception that was not caught then the state of the QueueRunner is never set back to IDLE or SCHEDULED.
> The code at the end of the method should be moved into the finally block to prevent this from happening.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3821) Uncaught exception thrown in QueueRunner.run() could cause QueueRunner to remain stuck in RUNNING state permanently

Posted by "Andrew MacBean (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew MacBean updated QPID-3821:
---------------------------------

    Attachment: 0001-QPID-3821-Uncaught-exception-thrown-in-QueueRunner.r.patch
    
> Uncaught exception thrown in QueueRunner.run() could cause QueueRunner to remain stuck in RUNNING state permanently
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3821
>                 URL: https://issues.apache.org/jira/browse/QPID-3821
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.15
>            Reporter: Andrew MacBean
>            Assignee: Andrew MacBean
>             Fix For: 0.15
>
>         Attachments: 0001-QPID-3821-Uncaught-exception-thrown-in-QueueRunner.r.patch
>
>
> The QueueRunner.run() method calls SimpleAMQQueue.processQueue(...) method within a try/catch block.  If this threw an exception that was not caught then the state of the QueueRunner is never set back to IDLE or SCHEDULED.
> The code at the end of the method should be moved into the finally block to prevent this from happening.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3821) Uncaught exception thrown in QueueRunner and SubFlushRunner run() could cause them to remain stuck in RUNNING state permanently

Posted by "Andrew MacBean (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew MacBean updated QPID-3821:
---------------------------------

    Attachment:     (was: 0001-QPID-3821-Uncaught-exception-thrown-in-QueueRunner.r.patch)
    
> Uncaught exception thrown in QueueRunner and SubFlushRunner run() could cause them to remain stuck in RUNNING state permanently
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3821
>                 URL: https://issues.apache.org/jira/browse/QPID-3821
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.15
>            Reporter: Andrew MacBean
>            Assignee: Keith Wall
>             Fix For: 0.15
>
>
> The QueueRunner.run() method calls SimpleAMQQueue.processQueue(...) method within a try/catch block.  If this threw an exception that was not caught then the state of the QueueRunner is never set back to IDLE or SCHEDULED.
> The same pattern is present in the SubFlushRunner.run().
> The code at the end of the method should be moved into the finally block to prevent this from happening.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3821) Uncaught exception thrown in QueueRunner and SubFlushRunner run() could cause them to remain stuck in RUNNING state permanently

Posted by "Andrew MacBean (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew MacBean updated QPID-3821:
---------------------------------

    Description: 
The QueueRunner.run() method calls SimpleAMQQueue.processQueue(...) method within a try/catch block.  If this threw an exception that was not caught then the state of the QueueRunner is never set back to IDLE or SCHEDULED.

The same pattern is present in the SubFlushRunner.run().

The code at the end of the method should be moved into the finally block to prevent this from happening.

  was:
The QueueRunner.run() method calls SimpleAMQQueue.processQueue(...) method within a try/catch block.  If this threw an exception that was not caught then the state of the QueueRunner is never set back to IDLE or SCHEDULED.

The code at the end of the method should be moved into the finally block to prevent this from happening.

        Summary: Uncaught exception thrown in QueueRunner and SubFlushRunner run() could cause them to remain stuck in RUNNING state permanently  (was: Uncaught exception thrown in QueueRunner.run() could cause QueueRunner to remain stuck in RUNNING state permanently)
    
> Uncaught exception thrown in QueueRunner and SubFlushRunner run() could cause them to remain stuck in RUNNING state permanently
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3821
>                 URL: https://issues.apache.org/jira/browse/QPID-3821
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.15
>            Reporter: Andrew MacBean
>            Assignee: Keith Wall
>             Fix For: 0.15
>
>
> The QueueRunner.run() method calls SimpleAMQQueue.processQueue(...) method within a try/catch block.  If this threw an exception that was not caught then the state of the QueueRunner is never set back to IDLE or SCHEDULED.
> The same pattern is present in the SubFlushRunner.run().
> The code at the end of the method should be moved into the finally block to prevent this from happening.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3821) Uncaught exception thrown in QueueRunner and SubFlushRunner run() could cause them to remain stuck in RUNNING state permanently

Posted by "Andrew MacBean (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew MacBean updated QPID-3821:
---------------------------------

    Attachment: 0001-QPID-3821-Uncaught-exception-thrown-in-QueueRunner.r.patch
    
> Uncaught exception thrown in QueueRunner and SubFlushRunner run() could cause them to remain stuck in RUNNING state permanently
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3821
>                 URL: https://issues.apache.org/jira/browse/QPID-3821
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.15
>            Reporter: Andrew MacBean
>            Assignee: Keith Wall
>             Fix For: 0.15
>
>         Attachments: 0001-QPID-3821-Uncaught-exception-thrown-in-QueueRunner.r.patch
>
>
> The QueueRunner.run() method calls SimpleAMQQueue.processQueue(...) method within a try/catch block.  If this threw an exception that was not caught then the state of the QueueRunner is never set back to IDLE or SCHEDULED.
> The same pattern is present in the SubFlushRunner.run().
> The code at the end of the method should be moved into the finally block to prevent this from happening.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Assigned] (QPID-3821) Uncaught exception thrown in QueueRunner.run() could cause QueueRunner to remain stuck in RUNNING state permanently

Posted by "Andrew MacBean (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew MacBean reassigned QPID-3821:
------------------------------------

    Assignee: Keith Wall  (was: Andrew MacBean)

Could you please review and apply if happy?

Thanks
Andrew
                
> Uncaught exception thrown in QueueRunner.run() could cause QueueRunner to remain stuck in RUNNING state permanently
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3821
>                 URL: https://issues.apache.org/jira/browse/QPID-3821
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.15
>            Reporter: Andrew MacBean
>            Assignee: Keith Wall
>             Fix For: 0.15
>
>         Attachments: 0001-QPID-3821-Uncaught-exception-thrown-in-QueueRunner.r.patch
>
>
> The QueueRunner.run() method calls SimpleAMQQueue.processQueue(...) method within a try/catch block.  If this threw an exception that was not caught then the state of the QueueRunner is never set back to IDLE or SCHEDULED.
> The code at the end of the method should be moved into the finally block to prevent this from happening.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org