You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/15 05:27:14 UTC
[GitHub] [flink] bowenli86 opened a new pull request #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
bowenli86 opened a new pull request #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
URL: https://github.com/apache/flink/pull/10857
…unctions in streaming mode
## What is the purpose of the change
Due to that Hive functions are all built for batch processing, aggregate functions in Hive that implement UDAF and GenericUDAFResolver2 interfaces may have unpredictable behaviors when used in streaming mode in Flink. We advice users to only use Hive aggregate functions interfaces in batch mode.
## Brief change log
update doc
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
n/a
## Documentation
n/a
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
URL: https://github.com/apache/flink/pull/10857#issuecomment-574504899
<!--
Meta data
Hash:016ef5f198f7bb200cdacf81fb1df0537951f4c5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144456221 TriggerType:PUSH TriggerID:016ef5f198f7bb200cdacf81fb1df0537951f4c5
Hash:016ef5f198f7bb200cdacf81fb1df0537951f4c5 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4354 TriggerType:PUSH TriggerID:016ef5f198f7bb200cdacf81fb1df0537951f4c5
-->
## CI report:
* 016ef5f198f7bb200cdacf81fb1df0537951f4c5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144456221) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
Posted by GitBox <gi...@apache.org>.
bowenli86 commented on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
URL: https://github.com/apache/flink/pull/10857#issuecomment-574502516
@xuefuz @lirui-apache @JingsongLi @zjffdu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
URL: https://github.com/apache/flink/pull/10857#issuecomment-574957473
> @JingsongLi This PR is for FLINK-15592
- Batch mode not work too.
- ROW_NUMBER is the function related to internal operator, can not be override.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
Posted by GitBox <gi...@apache.org>.
bowenli86 commented on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
URL: https://github.com/apache/flink/pull/10857#issuecomment-574890661
> Document is necessary, but may not be enough, is it possible to throw exception and display this error message at runtime ? @bowenli86
I'm not sure. Seems need to distinguish execution mode in FunctionCatalogOperatorTable, which is not achievable yet. I created https://issues.apache.org/jira/browse/FLINK-15607 to track
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zjffdu commented on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
URL: https://github.com/apache/flink/pull/10857#issuecomment-574956435
@JingsongLi This PR is for FLINK-15592
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zjffdu commented on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
URL: https://github.com/apache/flink/pull/10857#issuecomment-574504495
Document is good, but may not be enough, is it possible to throw exception and display this error message at runtime ? @bowenli86
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
URL: https://github.com/apache/flink/pull/10857#issuecomment-574504899
<!--
Meta data
Hash:016ef5f198f7bb200cdacf81fb1df0537951f4c5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144456221 TriggerType:PUSH TriggerID:016ef5f198f7bb200cdacf81fb1df0537951f4c5
Hash:016ef5f198f7bb200cdacf81fb1df0537951f4c5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4354 TriggerType:PUSH TriggerID:016ef5f198f7bb200cdacf81fb1df0537951f4c5
-->
## CI report:
* 016ef5f198f7bb200cdacf81fb1df0537951f4c5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144456221) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
URL: https://github.com/apache/flink/pull/10857#issuecomment-574504899
<!--
Meta data
Hash:016ef5f198f7bb200cdacf81fb1df0537951f4c5 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144456221 TriggerType:PUSH TriggerID:016ef5f198f7bb200cdacf81fb1df0537951f4c5
Hash:016ef5f198f7bb200cdacf81fb1df0537951f4c5 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4354 TriggerType:PUSH TriggerID:016ef5f198f7bb200cdacf81fb1df0537951f4c5
-->
## CI report:
* 016ef5f198f7bb200cdacf81fb1df0537951f4c5 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144456221) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zjffdu edited a comment on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
Posted by GitBox <gi...@apache.org>.
zjffdu edited a comment on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
URL: https://github.com/apache/flink/pull/10857#issuecomment-574504495
Document is necessary, but may not be enough, is it possible to throw exception and display this error message at runtime ? @bowenli86
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
URL: https://github.com/apache/flink/pull/10857#issuecomment-574504899
<!--
Meta data
Hash:016ef5f198f7bb200cdacf81fb1df0537951f4c5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:016ef5f198f7bb200cdacf81fb1df0537951f4c5
-->
## CI report:
* 016ef5f198f7bb200cdacf81fb1df0537951f4c5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
URL: https://github.com/apache/flink/pull/10857#issuecomment-574504899
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "016ef5f198f7bb200cdacf81fb1df0537951f4c5",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/144456221",
"triggerID" : "016ef5f198f7bb200cdacf81fb1df0537951f4c5",
"triggerType" : "PUSH"
}, {
"hash" : "016ef5f198f7bb200cdacf81fb1df0537951f4c5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4354",
"triggerID" : "016ef5f198f7bb200cdacf81fb1df0537951f4c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 016ef5f198f7bb200cdacf81fb1df0537951f4c5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144456221) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10857: [FLINK-15593][doc] add doc to remind users not using Hive aggregate f…
URL: https://github.com/apache/flink/pull/10857#issuecomment-574503085
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 016ef5f198f7bb200cdacf81fb1df0537951f4c5 (Wed Jan 15 05:30:42 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services