You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2023/10/31 14:01:23 UTC

[PR] [Bugfix][FFI] Typo fix of IncRef to DecRef [tvm]

Lunderberg opened a new pull request, #16021:
URL: https://github.com/apache/tvm/pull/16021

   Propagation of Python exceptions across C++ stack frames was introduced in https://github.com/apache/tvm/pull/15596.  This commit primarily fixes a typo in the initial implementation, where `Py_IncRef` was used instead of `Py_DecRef`.
   
   In addition, this PR resolves errors that were exposed by this typo fix, which caused test failures in `tests/python/unittest/test_crt.py::test_compile_runtime`.  These were due to use of the `Py_IncRef` and `Py_DecRef` functions on threads that hadn't acquired the GIL.  This usage error has been corrected for both the ctypes and cython FFI handling.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Bugfix][FFI] Typo fix of IncRef to DecRef [tvm]

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao merged PR #16021:
URL: https://github.com/apache/tvm/pull/16021


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org