[GitHub] [iceberg] jun-he commented on a change in pull request #3965: implement __eq__ for iceberg type classes.

[GitBox <gi...@apache.org>]

jun-he commented on a change in pull request #3965:
URL: https://github.com/apache/iceberg/pull/3965#discussion_r795135703



##########
File path: python/src/iceberg/types.py
##########
@@ -46,6 +46,9 @@ def __repr__(self):
     def __str__(self):
         return self._type_string
 
+    def __eq__(self, other):

Review comment:
       We can do that for some but not for types, e.g. FixedType.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org