[GitHub] [ozone] duongnguyen0 commented on a diff in pull request #3637: HDDS-6775. Add more performance logs to DataNode disk/container operations

[GitBox <gi...@apache.org>]

duongnguyen0 commented on code in PR #3637:
URL: https://github.com/apache/ozone/pull/3637#discussion_r943994132


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/ChunkUtils.java:
##########
@@ -137,6 +139,11 @@ private static void writeData(ChunkBuffer data, String filename,
       volume.getVolumeIOStats().incWriteBytes(bytesWritten);
     }
 
+    if (elapsed > DISK_IO_WARNING_THRESHOLD_MS) {

Review Comment:
   Should this and the following debug log be connected.
   ```
       if (elapsed > DISK_IO_WARNING_THRESHOLD_MS) {
         LOG.warn("Writing the chunk file {} into disk took {}ms",
             filename, elapsed);
       } else {
         LOG.debug("Written {} bytes at offset {} to {} in {} ms",
           bytesWritten, offset, filename, elapsed);
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org