[GitHub] [kafka] divijvaidya commented on a diff in pull request #13297: Kafka-14743: update request metrics after callback

["divijvaidya (via GitHub)" <gi...@apache.org>]

divijvaidya commented on code in PR #13297:
URL: https://github.com/apache/kafka/pull/13297#discussion_r1116858471


##########
core/src/test/scala/unit/kafka/server/FetchRequestDownConversionConfigTest.scala:
##########
@@ -163,7 +164,9 @@ class FetchRequestDownConversionConfigTest extends BaseRequestTest {
   }
 
   def testV1Fetch(isFollowerFetch: Boolean): Unit = {
+    val fetchMessageConversionsTimeMsMetricName = s"$MessageConversionsTimeMs,request=Fetch"

Review Comment:
   nit
   
   Is it possible to generate this string with some constants? e.g. we can use `RequestMetrics.MessageConversionsTimeMs`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org