[jira] Closed: (WINK-213) scrub code for debug log behavior

["Mike Rheinheimer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WINK-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Rheinheimer closed WINK-213.
---------------------------------


> scrub code for debug log behavior
> ---------------------------------
>
>                 Key: WINK-213
>                 URL: https://issues.apache.org/jira/browse/WINK-213
>             Project: Wink
>          Issue Type: Improvement
>            Reporter: Mike Rheinheimer
>            Assignee: Bryant Luk
>            Priority: Minor
>
> I've noticed, as I go through code, that some spots have the conditional surrounding the call to logger.debug, like so:
> {code}
>         if (logger.isDebugEnabled()) {
>             logger.debug("debug message");
>         }
> {code}
> Other places in code do not have the conditional.
> So, which is it?  Do we need the conditional or not?  I would assume we do need it because we don't know what the concrete implementation of Logger is in a given runtime container.
> If we do need it, is it worth putting a static boolean in a util class that is queried instead of calling isDebugEnabled every time?  This would give a very slight performance improvement as it would prevent a context switch into the isDebugEnabled method.
> I can work on cleaning all this up.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.