You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Oleg Ignatenko (JIRA)" <ji...@apache.org> on 2019/02/20 13:10:00 UTC

[jira] [Commented] (IGNITE-11012) [ML] Add model type validation during parsing json file

    [ https://issues.apache.org/jira/browse/IGNITE-11012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773003#comment-16773003 ] 

Oleg Ignatenko commented on IGNITE-11012:
-----------------------------------------

[~zaleslaw]  class {{SparkModelParserTest}} contains static import from old (JUnit 3) API: {{junit.framework.TestCase.fail;}} This is somewhat inconsistent because all the rest of the code in this class uses JUnit 4 API.

Consider changing this to newer API: {{import static org.junit.Assert.fail;}} to make everything uniform. (FWIW I tried such a change locally and tests executed fine)

> [ML] Add model type validation during parsing json file
> -------------------------------------------------------
>
>                 Key: IGNITE-11012
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11012
>             Project: Ignite
>          Issue Type: Sub-task
>          Components: ml
>    Affects Versions: 2.8
>            Reporter: Aleksey Zinoviev
>            Assignee: Aleksey Zinoviev
>            Priority: Major
>             Fix For: 2.8
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> After resolving ignite path, check special field in parquet file to validate apropriate model loading.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)