You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2022/09/08 01:10:36 UTC

[isis] branch master updated: Bump vaadin.version from 23.1.7 to 23.2.0 (2)

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new c45f0e1a30 Bump vaadin.version from 23.1.7 to 23.2.0 (2)
c45f0e1a30 is described below

commit c45f0e1a30e7f33decb43efde2353a7781001438
Author: Andi Huber <ah...@apache.org>
AuthorDate: Thu Sep 8 03:10:30 2022 +0200

    Bump vaadin.version from 23.1.7 to 23.2.0 (2)
    
    - build fix
---
 .../isis/incubator/viewer/vaadin/ui/pages/main/TabUtil.java | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/incubator/viewers/vaadin/ui/src/main/java/org/apache/isis/incubator/viewer/vaadin/ui/pages/main/TabUtil.java b/incubator/viewers/vaadin/ui/src/main/java/org/apache/isis/incubator/viewer/vaadin/ui/pages/main/TabUtil.java
index f81519a21e..715f60e0b7 100644
--- a/incubator/viewers/vaadin/ui/src/main/java/org/apache/isis/incubator/viewer/vaadin/ui/pages/main/TabUtil.java
+++ b/incubator/viewers/vaadin/ui/src/main/java/org/apache/isis/incubator/viewer/vaadin/ui/pages/main/TabUtil.java
@@ -36,11 +36,11 @@ import lombok.experimental.UtilityClass;
 @UtilityClass
 final class TabUtil {
 
-    static void createMenuTabs(MenuBarsServiceBS menuBarsService, Consumer<Tab> onTabCreated) {
+    static void createMenuTabs(final MenuBarsServiceBS menuBarsService, final Consumer<Tab> onTabCreated) {
         // onTabCreated.accept(TabUtil.createTab("Dashboard", DashboardView.class));
     }
 
-    static void selectTab(Tabs tabs, Class<? extends Component> viewClass) {
+    static void selectTab(final Tabs tabs, final Class<? extends Component> viewClass) {
         String target = RouteConfiguration.forSessionScope().getUrl(viewClass);
         Optional<Component> tabToSelect = tabs.getChildren().filter(tab -> {
             Component child = tab.getChildren().findFirst().get();
@@ -49,19 +49,20 @@ final class TabUtil {
         tabToSelect.ifPresent(tab -> tabs.setSelectedTab((Tab) tab));
     }
 
-    static Tab createTab(String title, Class<? extends Component> viewClass) {
-        return createTab(populateLink(new RouterLink(null, viewClass), title));
+    static Tab createTab(final String title, final Class<? extends Component> viewClass) {
+        final String text = null;
+        return createTab(populateLink(new RouterLink(text, viewClass), title));
     }
 
     // -- HELPER
 
-    private static Tab createTab(Component content) {
+    private static Tab createTab(final Component content) {
         final Tab tab = new Tab();
         tab.add(content);
         return tab;
     }
 
-    private static <T extends HasComponents> T populateLink(T a, String title) {
+    private static <T extends HasComponents> T populateLink(final T a, final String title) {
         a.add(title);
         return a;
     }