[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2458: Netbeans 4908

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #2458:
URL: https://github.com/apache/netbeans/pull/2458#discussion_r505239632



##########
File path: extide/gradle/test/unit/src/org/netbeans/modules/gradle/api/execute/RunUtilsTest.java
##########
@@ -70,4 +72,15 @@ public void testIncludeOpenProjects2() throws Exception {
         assertEquals(0, params.size());
     }
 
+    public void testEvaluateArgs1() throws Exception {
+        FileObject a = createGradleProject("projectA",
+                "apply plugin: 'java'\n", "");
+        Project prjA = ProjectManager.getDefault().findProject(a);
+        ProjectTrust.getDefault().trustProject(prjA);
+        openProject(a);
+        String[] args = RunUtils.evalueteActionArgs(prjA, null, "Project: ${projectPath}${projectName}", Lookups.singleton(prjA));

Review comment:
       Typo in `evalueteActionArgs`.

##########
File path: extide/gradle/src/org/netbeans/modules/gradle/spi/actions/ProjectActionMappingProvider.java
##########
@@ -17,13 +17,14 @@
  * under the License.
  */
 
-package org.netbeans.modules.gradle.actions;
+package org.netbeans.modules.gradle.spi.actions;
 
 import java.util.Set;
 import org.netbeans.modules.gradle.api.execute.ActionMapping;
 
 /**

Review comment:
       Consider adding better Javadoc. Description/example of "where/how to register this interface" was something I'd have expected here.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists