[GitHub] [spark] wypoon commented on issue #23767: [SPARK-26329][CORE][WIP] Faster polling of executor memory metrics.

[GitBox <gi...@apache.org>]

wypoon commented on issue #23767: [SPARK-26329][CORE][WIP] Faster polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#issuecomment-471122955
 
 
   > btw we should probably also update the docs on `ExecutorMetricType` to explain threading concerns, as its less clear now. IIUC, implementations do _not_ need to be thread-safe currently -- they will only be called by one thread at a time.
   
   For each executor (or the driver), the executor metrics are polled by a single thread, so I don't think there are any concerns there. It's only in the tracking of per-stage and per-task metric peaks that there are concurrency concerns around the data structures used to track them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org