You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/11 07:53:21 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #539: sched/sched:
Appease nxstyle errors
yamt opened a new pull request #539: sched/sched: Appease nxstyle errors
URL: https://github.com/apache/incubator-nuttx/pull/539
The remaining errors ("Missing space before closing C comment")
don't make sense. Maybe a bug in nxstyle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #539: sched/sched:
Appease nxstyle errors
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #539: sched/sched: Appease nxstyle errors
URL: https://github.com/apache/incubator-nuttx/pull/539#issuecomment-597677566
Now I see that some lone line fixes that I did in sched/sched/sched_mergepending.c are conflicting with something else. The version from #542 with the shorter lines is the one that is correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #539: sched/sched:
Appease nxstyle errors
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #539: sched/sched: Appease nxstyle errors
URL: https://github.com/apache/incubator-nuttx/pull/539#issuecomment-597634093
Let's wait for #542 to be merged and let the checks run again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #539:
sched/sched: Appease nxstyle errors
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #539: sched/sched: Appease nxstyle errors
URL: https://github.com/apache/incubator-nuttx/pull/539#issuecomment-597677566
Now I see that some long line fixes that I did in sched/sched/sched_mergepending.c are conflicting with something else. The version from #542 with the shorter lines is the one that is correct.
Ah.. I see that I have permission to resolve the conflict. Let's see what fails next.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #539: sched/sched:
Appease nxstyle errors
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #539: sched/sched: Appease nxstyle errors
URL: https://github.com/apache/incubator-nuttx/pull/539
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #539:
sched/sched: Appease nxstyle errors
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #539: sched/sched: Appease nxstyle errors
URL: https://github.com/apache/incubator-nuttx/pull/539#issuecomment-597677566
Now I see that some lone line fixes that I did in sched/sched/sched_mergepending.c are conflicting with something else. The version from #542 with the shorter lines is the one that is correct.
Ah.. I see that I have permission to resolve the conflict. Let's see what fails next.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #539: sched/sched:
Appease nxstyle errors
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #539: sched/sched: Appease nxstyle errors
URL: https://github.com/apache/incubator-nuttx/pull/539#issuecomment-597498957
> Maybe a bug in nxstyle.
https://github.com/apache/incubator-nuttx/issues/540
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #539:
sched/sched: Appease nxstyle errors
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #539: sched/sched: Appease nxstyle errors
URL: https://github.com/apache/incubator-nuttx/pull/539#issuecomment-597668330
> Let's wait for #542 to be merged and let the checks run again.
@yamt you can rebase this PR now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services