[jira] [Commented] (ARTEMIS-1926) Refactory SSLContext

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510185#comment-16510185 ] 

ASF GitHub Bot commented on ARTEMIS-1926:
-----------------------------------------

GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2138

    ARTEMIS-1926 refactor SSLContext

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1926

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2138
    
----
commit 6eaa009efcfb05b248621845f97a599c4b19904c
Author: Justin Bertram <jb...@...>
Date:   2018-06-12T20:27:48Z

    ARTEMIS-1926 refactor SSLContext

----


> Refactory SSLContext
> --------------------
>
>                 Key: ARTEMIS-1926
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1926
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.6.1
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>
> {{org.apache.activemq.artemis.core.remoting.impl.ssl.SSLSupport}} has ballooned in recent months with several additional options.  These new options have required additional constructors and the existing constructors were already a bit clumsy to use because for simple use-cases they required passing in multiple default values.  This class can be greatly simplified by adding properties, giving those properties reasonable defaults, and removing most of the static methods.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)