[jira] [Updated] (SPARK-20344) Duplicate call in FairSchedulableBuilder.addTaskSetManager

["Sean Owen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-20344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen updated SPARK-20344:
------------------------------
    Priority: Trivial  (was: Minor)

Does it cause any problem? yes you could probably rearrange this anyway to avoid the duplication. It's not really worth a JIRA.

> Duplicate call in FairSchedulableBuilder.addTaskSetManager
> ----------------------------------------------------------
>
>                 Key: SPARK-20344
>                 URL: https://issues.apache.org/jira/browse/SPARK-20344
>             Project: Spark
>          Issue Type: Improvement
>          Components: Scheduler
>    Affects Versions: 2.1.0
>            Reporter: Robert Stupp
>            Priority: Trivial
>
> {{org.apache.spark.scheduler.FairSchedulableBuilder#addTaskSetManager}} contains the code snippet:
> {code}
>   override def addTaskSetManager(manager: Schedulable, properties: Properties) {
>     var poolName = DEFAULT_POOL_NAME
>     var parentPool = rootPool.getSchedulableByName(poolName)
>     if (properties != null) {
>       poolName = properties.getProperty(FAIR_SCHEDULER_PROPERTIES, DEFAULT_POOL_NAME)
>       parentPool = rootPool.getSchedulableByName(poolName)
>       if (parentPool == null) {
> {code}
> {{parentPool = rootPool.getSchedulableByName(poolName)}} is called twice if {{properties != null}}.
> I'm not sure whether this is an oversight or there's something else missing. This piece of the code hasn't been modified since 2013, so I doubt that this is a serious issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org