You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/04/13 02:44:04 UTC
[GitHub] incubator-brooklyn pull request: REST api domain objects Serializa...
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/594
REST api domain objects Serializable
- Makes everything in brooklyn.rest.domain.* serialisable
- Useful for users of brooklyn.rest.client.BrooklynApi, where
they use these Java objects. Serialisable is not necessary,
but for subsequent usage (e.g. in a mule flow) then it is
useful if they are.
See related PR #583 which has already been merged.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/restApi-serializable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/594.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #594
----
commit 1bb097886c6c72db3ed5310d398d7c1d8068eda1
Author: Aled Sage <al...@gmail.com>
Date: 2015-04-13T00:33:28Z
REST api domain objects Serializable
- Makes everything in brooklyn.rest.domain.* serialisable
- Useful for users of brooklyn.rest.client.BrooklynApi, where
they use these Java objects. Serialisable is not necessary,
but for subsequent usage (e.g. in a mule flow) then it is
useful if they are.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: REST api domain objects Serializa...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/594#discussion_r28209675
--- Diff: usage/rest-api/src/main/java/brooklyn/rest/domain/EntitySpec.java ---
@@ -19,14 +19,19 @@
package brooklyn.rest.domain;
import static com.google.common.base.Preconditions.checkNotNull;
+
import com.google.common.collect.ImmutableMap;
+
import org.codehaus.jackson.annotate.JsonProperty;
+import java.io.Serializable;
import java.util.Collections;
import java.util.Map;
-public class EntitySpec implements HasName {
+public class EntitySpec implements HasName, Serializable {
--- End diff --
I see they are already strings, so not an issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: REST api domain objects Serializa...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/594#issuecomment-92821628
@ahgittin `CatalogEntitySummary` extends `CatalogItemSummary` so is `Serializable`. Do you think we want to include `implements Serializable` on the sub-class as well, in case someone refactors it later and doesn't look at the super-class? I'm fine with as-is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: REST api domain objects Serializa...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/594#issuecomment-93436817
Merging :frog:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: REST api domain objects Serializa...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/594#discussion_r28209654
--- Diff: usage/rest-api/src/main/java/brooklyn/rest/domain/EntitySpec.java ---
@@ -19,14 +19,19 @@
package brooklyn.rest.domain;
import static com.google.common.base.Preconditions.checkNotNull;
+
import com.google.common.collect.ImmutableMap;
+
import org.codehaus.jackson.annotate.JsonProperty;
+import java.io.Serializable;
import java.util.Collections;
import java.util.Map;
-public class EntitySpec implements HasName {
+public class EntitySpec implements HasName, Serializable {
--- End diff --
Does this restrict the possible values for spec configuration to serializable instances only?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: REST api domain objects Serializa...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/594#issuecomment-92344548
several files are missing `Serializable` -- e.g. `CatalogEntitySummary` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: REST api domain objects Serializa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/594
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: REST api domain objects Serializa...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/594#issuecomment-92851686
Ah of course. Merge away.
On 14 Apr 2015 08:16, "Aled Sage" <no...@github.com> wrote:
> @ahgittin <https://github.com/ahgittin> CatalogEntitySummary extends
> CatalogItemSummary so is Serializable. Do you think we want to include implements
> Serializable on the sub-class as well, in case someone refactors it later
> and doesn't look at the super-class? I'm fine with as-is.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-brooklyn/pull/594#issuecomment-92821628>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---