You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2015/11/12 23:41:56 UTC
Review Request 40118: [1/6] Added 'principal' field to
'Resource.DiskInfo.Persistence'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40118/
-----------------------------------------------------------
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Bugs: MESOS-3064
https://issues.apache.org/jira/browse/MESOS-3064
Repository: mesos
Description
-------
Added 'principal' field to 'Resource.DiskInfo.Persistence'.
Diffs
-----
include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b
include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b
Diff: https://reviews.apache.org/r/40118/diff/
Testing
-------
This is the first in a chain of 6 patches. `make check` was used to test after all patches were applied.
Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
Thanks,
Greg Mann
Re: Review Request 40118: [1/7] Added 'principal' field to
'Resource.DiskInfo.Persistence'.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40118/#review108798
-----------------------------------------------------------
include/mesos/mesos.proto (lines 629 - 631)
<https://reviews.apache.org/r/40118/#comment168278>
Let's leave a note why it's marked `optional`, which is inconsistent to `ReservationInfo.principal`. For symmetry, maybe it makes sense to add a `TODO` around `ReservationInfo.principal` that we may change it to optional as well
- Alexander Rukletsov
On Dec. 2, 2015, 9:42 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40118/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 9:42 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3064
> https://issues.apache.org/jira/browse/MESOS-3064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added 'principal' field to 'Resource.DiskInfo.Persistence'.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 27971fea6935b82d7034397edaa7a37edb1f6f38
> include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd
>
> Diff: https://reviews.apache.org/r/40118/diff/
>
>
> Testing
> -------
>
> This is the first in a chain of 7 patches. `make check` was used to test after all patches were applied.
>
> Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
>
> One additional patch with documentation is forthcoming.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40118: [1/7] Added 'principal' field to
'Resource.DiskInfo.Persistence'.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40118/#review109035
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On Dec. 3, 2015, 11:37 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40118/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 11:37 p.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3064
> https://issues.apache.org/jira/browse/MESOS-3064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added 'principal' field to 'Resource.DiskInfo.Persistence'.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 671365eb541418eeb60f029f8ef1d73abf6ef61d
> include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd
>
> Diff: https://reviews.apache.org/r/40118/diff/
>
>
> Testing
> -------
>
> This is the first in a chain of 7 patches. `make check` was used to test after all patches were applied.
>
> Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
>
> One additional patch with documentation is forthcoming.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40118: [1/7] Added 'principal' field to
'Resource.DiskInfo.Persistence'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40118/#review109041
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 3, 2015, 11:37 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40118/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 11:37 p.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3064
> https://issues.apache.org/jira/browse/MESOS-3064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added 'principal' field to 'Resource.DiskInfo.Persistence'.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 671365eb541418eeb60f029f8ef1d73abf6ef61d
> include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd
>
> Diff: https://reviews.apache.org/r/40118/diff/
>
>
> Testing
> -------
>
> This is the first in a chain of 7 patches. `make check` was used to test after all patches were applied.
>
> Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
>
> One additional patch with documentation is forthcoming.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40118: [1/7] Added 'principal' field to
'Resource.DiskInfo.Persistence'.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40118/
-----------------------------------------------------------
(Updated Dec. 3, 2015, 11:37 p.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Changes
-------
Added comments.
Bugs: MESOS-3064
https://issues.apache.org/jira/browse/MESOS-3064
Repository: mesos
Description
-------
Added 'principal' field to 'Resource.DiskInfo.Persistence'.
Diffs (updated)
-----
include/mesos/mesos.proto 671365eb541418eeb60f029f8ef1d73abf6ef61d
include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd
Diff: https://reviews.apache.org/r/40118/diff/
Testing
-------
This is the first in a chain of 7 patches. `make check` was used to test after all patches were applied.
Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
One additional patch with documentation is forthcoming.
Thanks,
Greg Mann
Re: Review Request 40118: [1/7] Added 'principal' field to
'Resource.DiskInfo.Persistence'.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40118/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 9:42 a.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Changes
-------
Rebase.
Bugs: MESOS-3064
https://issues.apache.org/jira/browse/MESOS-3064
Repository: mesos
Description
-------
Added 'principal' field to 'Resource.DiskInfo.Persistence'.
Diffs (updated)
-----
include/mesos/mesos.proto 27971fea6935b82d7034397edaa7a37edb1f6f38
include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd
Diff: https://reviews.apache.org/r/40118/diff/
Testing
-------
This is the first in a chain of 7 patches. `make check` was used to test after all patches were applied.
Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
One additional patch with documentation is forthcoming.
Thanks,
Greg Mann
Re: Review Request 40118: [1/7] Added 'principal' field to
'Resource.DiskInfo.Persistence'.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40118/
-----------------------------------------------------------
(Updated Nov. 30, 2015, 9:40 p.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Changes
-------
Rebase.
Bugs: MESOS-3064
https://issues.apache.org/jira/browse/MESOS-3064
Repository: mesos
Description
-------
Added 'principal' field to 'Resource.DiskInfo.Persistence'.
Diffs (updated)
-----
include/mesos/mesos.proto 27971fea6935b82d7034397edaa7a37edb1f6f38
include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd
Diff: https://reviews.apache.org/r/40118/diff/
Testing
-------
This is the first in a chain of 7 patches. `make check` was used to test after all patches were applied.
Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
One additional patch with documentation is forthcoming.
Thanks,
Greg Mann
Re: Review Request 40118: [1/7] Added 'principal' field to
'Resource.DiskInfo.Persistence'.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40118/
-----------------------------------------------------------
(Updated Nov. 14, 2015, 12:21 a.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Changes
-------
Rebase.
Bugs: MESOS-3064
https://issues.apache.org/jira/browse/MESOS-3064
Repository: mesos
Description
-------
Added 'principal' field to 'Resource.DiskInfo.Persistence'.
Diffs (updated)
-----
include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b
include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b
Diff: https://reviews.apache.org/r/40118/diff/
Testing
-------
This is the first in a chain of 7 patches. `make check` was used to test after all patches were applied.
Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
One additional patch with documentation is forthcoming.
Thanks,
Greg Mann
Re: Review Request 40118: [1/7] Added 'principal' field to
'Resource.DiskInfo.Persistence'.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Nov. 13, 2015, 10:33 a.m., Neil Conway wrote:
> > include/mesos/mesos.proto, line 623
> > <https://reviews.apache.org/r/40118/diff/1/?file=1124444#file1124444line623>
> >
> > Note that this will require changes in the HTTP endpoint patch. (Just observing that whichever patch gets committed first, the other will need to be updated.)
Yea that's true. I have an issue open (MESOS-3903) to add authorization support to the `/create-volume` and `/destroy-volume` HTTP endpoints; I figured I would split that work off into a separate ticket to avoid a dependency on your HTTP endpoint patches. Currently in this series, there are several comments (including this one) which suggest that authorization support for endpoints is being added here as well; perhaps I should avoid making that claim right now and add endpoint support into the comments/docs when MESOS-3903 is being addressed.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40118/#review106393
-----------------------------------------------------------
On Nov. 13, 2015, 1:22 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40118/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 1:22 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3064
> https://issues.apache.org/jira/browse/MESOS-3064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added 'principal' field to 'Resource.DiskInfo.Persistence'.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b
> include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b
>
> Diff: https://reviews.apache.org/r/40118/diff/
>
>
> Testing
> -------
>
> This is the first in a chain of 7 patches. `make check` was used to test after all patches were applied.
>
> Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
>
> One additional patch with documentation is forthcoming.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40118: [1/7] Added 'principal' field to
'Resource.DiskInfo.Persistence'.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40118/#review106393
-----------------------------------------------------------
include/mesos/mesos.proto (line 623)
<https://reviews.apache.org/r/40118/#comment165138>
Note that this will require changes in the HTTP endpoint patch. (Just observing that whichever patch gets committed first, the other will need to be updated.)
- Neil Conway
On Nov. 13, 2015, 1:22 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40118/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 1:22 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3064
> https://issues.apache.org/jira/browse/MESOS-3064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added 'principal' field to 'Resource.DiskInfo.Persistence'.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b
> include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b
>
> Diff: https://reviews.apache.org/r/40118/diff/
>
>
> Testing
> -------
>
> This is the first in a chain of 7 patches. `make check` was used to test after all patches were applied.
>
> Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
>
> One additional patch with documentation is forthcoming.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40118: [1/7] Added 'principal' field to
'Resource.DiskInfo.Persistence'.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40118/
-----------------------------------------------------------
(Updated Nov. 13, 2015, 1:22 a.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Bugs: MESOS-3064
https://issues.apache.org/jira/browse/MESOS-3064
Repository: mesos
Description
-------
Added 'principal' field to 'Resource.DiskInfo.Persistence'.
Diffs
-----
include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b
include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b
Diff: https://reviews.apache.org/r/40118/diff/
Testing (updated)
-------
This is the first in a chain of 7 patches. `make check` was used to test after all patches were applied.
Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
One additional patch with documentation is forthcoming.
Thanks,
Greg Mann
Re: Review Request 40118: [1/7] Added 'principal' field to
'Resource.DiskInfo.Persistence'.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40118/
-----------------------------------------------------------
(Updated Nov. 13, 2015, 1:19 a.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Summary (updated)
-----------------
[1/7] Added 'principal' field to 'Resource.DiskInfo.Persistence'.
Bugs: MESOS-3064
https://issues.apache.org/jira/browse/MESOS-3064
Repository: mesos
Description
-------
Added 'principal' field to 'Resource.DiskInfo.Persistence'.
Diffs
-----
include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b
include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b
Diff: https://reviews.apache.org/r/40118/diff/
Testing
-------
This is the first in a chain of 6 patches. `make check` was used to test after all patches were applied.
Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
One additional patch with documentation is forthcoming.
Thanks,
Greg Mann
Re: Review Request 40118: [1/6] Added 'principal' field to
'Resource.DiskInfo.Persistence'.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40118/
-----------------------------------------------------------
(Updated Nov. 12, 2015, 11:26 p.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Bugs: MESOS-3064
https://issues.apache.org/jira/browse/MESOS-3064
Repository: mesos
Description
-------
Added 'principal' field to 'Resource.DiskInfo.Persistence'.
Diffs
-----
include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b
include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b
Diff: https://reviews.apache.org/r/40118/diff/
Testing (updated)
-------
This is the first in a chain of 6 patches. `make check` was used to test after all patches were applied.
Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
One additional patch with documentation is forthcoming.
Thanks,
Greg Mann