You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 23:34:42 UTC

[GitHub] [beam] damccorm opened a new issue, #21464: GroupIntoBatchesTest is failing

damccorm opened a new issue, #21464:
URL: https://github.com/apache/beam/issues/21464

   Currently failing a test on core sdk on the following assertion. From the test description, it seems like (totalNumBatches <= numElements && totalNumBatches \>= numElements / batchSize) is what is wanted instead, but currently it is testing for numFullBatches instead and is failing the test. Is this intended?
   
    
   
   Current code:
   
   assertTrue( String.format( "total number of batches should be in the range [%d, %d] but got %d", numElements, numElements / batchSize, numFullBatches), numFullBatches <= numElements && numFullBatches \>= numElements / batchSize)
   
   Source:
   
   [https://github.com/apache/beam/blob/v2.34.0/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/GroupIntoBatchesTest.java#L295](https://github.com/apache/beam/blob/v2.34.0/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/GroupIntoBatchesTest.java#L295)
   
   Imported from Jira [BEAM-13393](https://issues.apache.org/jira/browse/BEAM-13393). Original Jira may contain additional context.
   Reported by: fructokinase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] jrmccluskey commented on issue #21464: GroupIntoBatchesTest is failing

Posted by GitBox <gi...@apache.org>.
jrmccluskey commented on issue #21464:
URL: https://github.com/apache/beam/issues/21464#issuecomment-1284144793

   Test is passing on CI, cannot reproduce.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] jrmccluskey closed issue #21464: GroupIntoBatchesTest is failing

Posted by GitBox <gi...@apache.org>.
jrmccluskey closed issue #21464: GroupIntoBatchesTest is failing
URL: https://github.com/apache/beam/issues/21464


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org