You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "rabajaj0509 (via GitHub)" <gi...@apache.org> on 2023/03/07 00:06:08 UTC
[GitHub] [skywalking-kubernetes] rabajaj0509 opened a new pull request, #108: Feature-#10481 - use startup probe option for first initialization of application
rabajaj0509 opened a new pull request, #108:
URL: https://github.com/apache/skywalking-kubernetes/pull/108
Applications take longer to start up the first time. In these situations, setting up liveness probe parameters might be challenging without sacrificing the quick response time that led to the probe's creation. Setting up a startup probe with the same command, TCP check, and a failureThreshold* periodSeconds long enough to account for the worst-case startup delay is therefore a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 merged pull request #108: Feature-#10481 - use startup probe option for first initialization of application
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 merged PR #108:
URL: https://github.com/apache/skywalking-kubernetes/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 commented on a diff in pull request #108: Feature-#10481 - use startup probe option for first initialization of application
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #108:
URL: https://github.com/apache/skywalking-kubernetes/pull/108#discussion_r1127197323
##########
chart/skywalking/templates/oap-deployment.yaml:
##########
@@ -96,17 +96,26 @@ spec:
{{ else }}
tcpSocket:
port: 12800
- initialDelaySeconds: 15
- periodSeconds: 20
+ initialDelaySeconds: 5
+ periodSeconds: 10
+{{ end }}
+ startupProbe:
+{{- if .Values.oap.startupProbe}}
+{{ toYaml .Values.oap.startupProbe | indent 10 }}
+{{ else }}
+ tcpSocket:
+ port: 12800
+ failureThreshold: 9
+ periodSeconds: 10
Review Comment:
What do you think if we remove this (Line 106 ~ Line 109`) and uncomment the `startupProbe` section in `values.yaml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 commented on a diff in pull request #108: Feature-#10481 - use startup probe option for first initialization of application
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #108:
URL: https://github.com/apache/skywalking-kubernetes/pull/108#discussion_r1127197323
##########
chart/skywalking/templates/oap-deployment.yaml:
##########
@@ -96,17 +96,26 @@ spec:
{{ else }}
tcpSocket:
port: 12800
- initialDelaySeconds: 15
- periodSeconds: 20
+ initialDelaySeconds: 5
+ periodSeconds: 10
+{{ end }}
+ startupProbe:
+{{- if .Values.oap.startupProbe}}
+{{ toYaml .Values.oap.startupProbe | indent 10 }}
+{{ else }}
+ tcpSocket:
+ port: 12800
+ failureThreshold: 9
+ periodSeconds: 10
Review Comment:
What do you think if we remove this (Line 106 ~ Line 109) and uncomment the `startupProbe` section in `values.yaml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org