You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "mattisonchao (via GitHub)" <gi...@apache.org> on 2023/08/17 12:17:23 UTC

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #21010: [fix] [auto-recovery] Fix deadlock in AutoRecovery.

mattisonchao commented on code in PR #21010:
URL: https://github.com/apache/pulsar/pull/21010#discussion_r1297136442


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/PulsarLedgerUnderreplicationManager.java:
##########
@@ -978,11 +978,13 @@ public long getReplicasCheckCTime() throws ReplicationException.UnavailableExcep
     @Override
     public void notifyUnderReplicationLedgerChanged(BookkeeperInternalCallbacks.GenericCallback<Void> cb)

Review Comment:
   Do you think we should consider deprecating this method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org