[GitHub] incubator-guacamole-client pull request #195: GUACAMOLE-408: Use Docker mult...

[ceharris <gi...@git.apache.org>]

GitHub user ceharris opened a pull request:

    https://github.com/apache/incubator-guacamole-client/pull/195

    GUACAMOLE-408: Use Docker multi-stage build to create guacamole image

    Since Docker CE 17.05 (edge) and 17.06 (stable), multi-stage builds to create images using a different base images for build versus runtime.
    
    This allows the build itself to be used with the official Maven image, rather than using the Tomcat image as the base and installing the necessary dependencies for performing the Guacamole build. It also obviates to the need to clean up after the build. In the second stage of the build, the official Tomcat image is used at the base for the runtime image. The artifacts built in the first stage are simply copied from the build stage into the runtime stage.
    
    Taking advantage of another minor feature added in Docker CE 17.05, the Tomcat version and JRE details are specified using build arguments. This allows the Tomcat or JRE to be easily varied by the image builder. For example, minimalists may wish to build using `docker image build --build-arg TOMCAT_JRE=jre8-alpine` to get a smaller runtime image.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soulwing/incubator-guacamole-client GUACAMOLE-408

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-client/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #195
    
----
commit 5c07e4a4eeabf68c5fa1ea24ced373ac8d697bbf
Author: Carl Harris <ce...@vt.edu>
Date:   2017-10-07T14:07:20Z

    GUACAMOLE-408: revise Dockerfile to use multi-stage image build

commit ac50375ad526ba6f1453ca10e32b6f393e6e486d
Author: Carl Harris <ce...@vt.edu>
Date:   2017-10-07T14:09:18Z

    GUACAMOLE-408: don't try to clean up the local Maven repository
    
    There's no need to clean up the local Maven repository after the
    build, since only the artifacts we want are copied to the runtime
    image. For reasons not investigated, attempting to remove the
    local repository directory fails because the directory is in use
    after the build.

commit 70db9a4c42418fdc520e4f3d6414a0e753a79266
Author: Carl Harris <ce...@vt.edu>
Date:   2017-10-07T14:12:49Z

    GUACAMOLE-408: exclude generated HTML files from rat validation
    
    When building inside of the Docker container, some files with
    generated HTML are being validated by RAT and failing due to the
    lack of a license header. When building outside of Docker, this
    problem does not occur. Not sure why these paths don't fail when
    building outside of the container, and I don't know enough about
    the plugin that generates these files to understand why it behaves
    differently inside of the container. Nonetheless, I think these
    excludes seem reasonable.

----


---

[GitHub] incubator-guacamole-client pull request #195: GUACAMOLE-408: Use Docker mult...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-guacamole-client/pull/195


---