[GitHub] [cassandra] jasonstack commented on a change in pull request #446: CASSANDRA-15564 Refactor repair coordinator to centralize stage change logic and improved the public facing errors

[GitBox <gi...@apache.org>]

jasonstack commented on a change in pull request #446: CASSANDRA-15564 Refactor repair coordinator to centralize stage change logic and improved the public facing errors
URL: https://github.com/apache/cassandra/pull/446#discussion_r390101382
 
 

 ##########
 File path: src/java/org/apache/cassandra/repair/RepairRunnable.java
 ##########
 @@ -131,167 +145,239 @@ protected void fireProgressEvent(ProgressEvent event)
         }
     }
 
-    protected void fireErrorAndComplete(int progressCount, int totalProgress, String message)
+    private void skip(String msg)
+    {
+        logger.info("Repair {} skipped: {}", parentSession, msg);
+        fireProgressEvent(new ProgressEvent(ProgressEventType.NOTIFICATION, 100, 100, "Repair " + parentSession + " skipped: " + msg));
 
 Review comment:
   When there is no valid CFs to be repaired, a skip event with 100/100 progress is fired, and then another `success` event with `progressCounter/totalProgress` is fired in `success()`.. 
   
   Should we use `progressCounter/totalProgress` for skip progress event?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org