You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/10/21 08:08:56 UTC

[GitHub] [incubator-devlake] klesh commented on issue #3537: [Bug][pipeline] pipeline cannot work after migration failed

klesh commented on issue #3537:
URL: https://github.com/apache/incubator-devlake/issues/3537#issuecomment-1286614962

   Related to https://github.com/apache/incubator-devlake/issues/3508
   
   Due to migration failure, the maximum id of the `pipelines` table is smaller than expected, however, the `tasks` table migrated successfully, so it contained more `pipeline_id` than `pipelines` table.
   When creating new pipelines, the `pipeline_id` in `tasks` table collides which causes the pipeline having more `tasks` than expected, in this case, https://github.com/apache/incubator-devlake/blob/release-v0.14/runner/run_pipeline.go#L54 triggered, return without setting the `beganAt` for the `pipeline` which leads to the final error.
   
   As you can tell, it is tedious to track down and explain what was wrong. It would be much better to put `beganAt` and `spentSeconds` for robustness so we can see what was wrong right away. However, it was designed this way because of `temporal mode`(related to `beganAt`) and `panicking catch`(must be dealt with in a caller function). 
   
   I need more time to come out a better solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org