[GitHub] [arrow] wjones1 commented on a change in pull request #6979: ARROW-7800 [Python] implement iter_batches() method for ParquetFile and ParquetReader

[GitBox <gi...@apache.org>]

wjones1 commented on a change in pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#discussion_r414948745



##########
File path: cpp/src/parquet/arrow/reader.cc
##########
@@ -260,12 +260,28 @@ class FileReaderImpl : public FileReader {
 
   Status GetRecordBatchReader(const std::vector<int>& row_group_indices,
                               const std::vector<int>& column_indices,
-                              std::unique_ptr<RecordBatchReader>* out) override;
+                              std::unique_ptr<RecordBatchReader>* out,

Review comment:
       Thanks for the feedback. I think I understand now the pattern going on with `set_use_threads()`. It's a method on the reader that [calls the method of the same name it's `ArrowReaderProperties`](https://github.com/apache/arrow/blob/master/cpp/src/parquet/arrow/reader.cc#L279-L281).
   
   I will implement the same thing for [the `set_batch_size()`](https://github.com/apache/arrow/blob/master/cpp/src/parquet/properties.h#L564) method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org