You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "valepakh (via GitHub)" <gi...@apache.org> on 2026/02/20 11:40:22 UTC
[PR] IGNITE-27935 Add checkstyle rule to detect logger names mismatches [ignite-3]
valepakh opened a new pull request, #7642:
URL: https://github.com/apache/ignite-3/pull/7642
https://issues.apache.org/jira/browse/IGNITE-27935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27935 Add checkstyle rule to detect logger names mismatches [ignite-3]
Posted by "PakhomovAlexander (via GitHub)" <gi...@apache.org>.
PakhomovAlexander merged PR #7642:
URL: https://github.com/apache/ignite-3/pull/7642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27935 Add checkstyle rule to detect logger names mismatches [ignite-3]
Posted by "valepakh (via GitHub)" <gi...@apache.org>.
valepakh commented on code in PR #7642:
URL: https://github.com/apache/ignite-3/pull/7642#discussion_r2832955657
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgnitePlanner.java:
##########
@@ -657,7 +657,7 @@ public void disableRules(Collection<String> ruleNamesToDisable) {
}
private static class VolcanoPlannerExt extends VolcanoPlanner {
- private static final IgniteLogger LOG = Loggers.forClass(IgnitePlanner.class);
+ private static final IgniteLogger LOG = Loggers.forClass(VolcanoPlannerExt.class);
Review Comment:
I added the exclude property but in this particular case I moved the logger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27935 Add checkstyle rule to detect logger names mismatches [ignite-3]
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich commented on code in PR #7642:
URL: https://github.com/apache/ignite-3/pull/7642#discussion_r2832907982
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgnitePlanner.java:
##########
@@ -657,7 +657,7 @@ public void disableRules(Collection<String> ruleNamesToDisable) {
}
private static class VolcanoPlannerExt extends VolcanoPlanner {
- private static final IgniteLogger LOG = Loggers.forClass(IgnitePlanner.class);
+ private static final IgniteLogger LOG = Loggers.forClass(VolcanoPlannerExt.class);
Review Comment:
it will be better to return back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27935 Add checkstyle rule to detect logger names mismatches [ignite-3]
Posted by "valepakh (via GitHub)" <gi...@apache.org>.
valepakh commented on code in PR #7642:
URL: https://github.com/apache/ignite-3/pull/7642#discussion_r2832917795
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgnitePlanner.java:
##########
@@ -657,7 +657,7 @@ public void disableRules(Collection<String> ruleNamesToDisable) {
}
private static class VolcanoPlannerExt extends VolcanoPlanner {
- private static final IgniteLogger LOG = Loggers.forClass(IgnitePlanner.class);
+ private static final IgniteLogger LOG = Loggers.forClass(VolcanoPlannerExt.class);
Review Comment:
I'd rather move the logger to the outer class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org