[jira] [Created] (MENFORCER-420) Reuse getDependenciesToCheck results across rules

["Joseph Walton (Jira)" <ji...@apache.org>]

Joseph Walton created MENFORCER-420:
---------------------------------------

             Summary: Reuse getDependenciesToCheck results across rules
                 Key: MENFORCER-420
                 URL: https://issues.apache.org/jira/browse/MENFORCER-420
             Project: Maven Enforcer Plugin
          Issue Type: Improvement
          Components: Standard Rules
            Reporter: Joseph Walton


We have a build with a significant number of dependencies, and also a large number of {{<bannedDependencies/>}} rules. Together, they lead to a build where Enforcer takes tens of minutes.

Looking into bottlenecks, we found that {{AbstractBanDependencies#getDependenciesToCheck}} was taking a significant proportion of the build time (tens of percent). This method is called once per rule, so it's recalculating the dependencies for every rule across every execution.

Introducing a cache, to reuse the dependencies one they'd been calculated for a module, dropped the time spent in banned dependency enforcement by about 75%, which was reflected as a 60% improvement in the time of that build.

Our local implementation used the {{org.codehaus.plexus.context.Context}} to store the dependencies keyed by the concatenation of {{MavenProject#getId}} and {{searchTransitive}}; there may be a more appropriate scope to avoid edge cases with complex configurations.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)