You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2012/07/12 12:10:34 UTC
[jira] [Created] (QPID-4131) Broker should close connection on
transaction timeout rather than close session for better compatibility with
Java clients
Keith Wall created QPID-4131:
--------------------------------
Summary: Broker should close connection on transaction timeout rather than close session for better compatibility with Java clients
Key: QPID-4131
URL: https://issues.apache.org/jira/browse/QPID-4131
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: 0.16, 0.14, 0.12, 0.18
Reporter: Keith Wall
Assignee: Keith Wall
Fix For: 0.19
Older versions of the Java Broker (0.5) used to close the connection in the event of transaction time (on detection of open or idle transaction) rather than close the session. When the transaction timeout feature was forward ported to 0.11, the decision was made to close the session for both 0-10 and 0-8...0-9-1. Unfortunately the Java client does not handle the session close correctly and this results in a connection leak.
This change will revert the 0-8...0-9-1 code paths within the Java Broker to use connection close rather than session close. This will ensure that the Java Broker remains compatibility with Java Clients that suffer this problem..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4131) Broker should close connection on
transaction timeout rather than close session for better compatibility with
Java clients
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4131:
-----------------------------
Affects Version/s: (was: 0.18)
Fix Version/s: 0.18
Applied to 0.18 branch.
> Broker should close connection on transaction timeout rather than close session for better compatibility with Java clients
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-4131
> URL: https://issues.apache.org/jira/browse/QPID-4131
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.12, 0.14, 0.16
> Reporter: Keith Wall
> Assignee: Philip Harvey
> Fix For: 0.18, 0.19
>
>
> Older versions of the Java Broker (0.5) used to close the connection in the event of transaction time (on detection of open or idle transaction) rather than close the session. When the transaction timeout feature was forward ported to 0.11, the decision was made to close the session for both 0-10 and 0-8...0-9-1. Unfortunately the Java client does not handle the session close correctly and this results in a connection leak.
> This change will revert the 0-8...0-9-1 code paths within the Java Broker to use connection close rather than session close. This will ensure that the Java Broker remains compatibility with Java Clients that suffer this problem..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4131) Broker should close connection on
transaction timeout rather than close session for better compatibility with
Java clients
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-4131:
--------------------------------
Assignee: Philip Harvey (was: Keith Wall)
Hi Phil, could you review please?
> Broker should close connection on transaction timeout rather than close session for better compatibility with Java clients
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-4131
> URL: https://issues.apache.org/jira/browse/QPID-4131
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.12, 0.14, 0.16, 0.18
> Reporter: Keith Wall
> Assignee: Philip Harvey
> Fix For: 0.19
>
>
> Older versions of the Java Broker (0.5) used to close the connection in the event of transaction time (on detection of open or idle transaction) rather than close the session. When the transaction timeout feature was forward ported to 0.11, the decision was made to close the session for both 0-10 and 0-8...0-9-1. Unfortunately the Java client does not handle the session close correctly and this results in a connection leak.
> This change will revert the 0-8...0-9-1 code paths within the Java Broker to use connection close rather than session close. This will ensure that the Java Broker remains compatibility with Java Clients that suffer this problem..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4131) Broker should close connection on
transaction timeout rather than close session for better compatibility with
Java clients
Posted by "Justin Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416699#comment-13416699 ]
Justin Ross commented on QPID-4131:
-----------------------------------
Reviewed by Philip. Approved for 0.18.
> Broker should close connection on transaction timeout rather than close session for better compatibility with Java clients
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-4131
> URL: https://issues.apache.org/jira/browse/QPID-4131
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.12, 0.14, 0.16, 0.18
> Reporter: Keith Wall
> Assignee: Philip Harvey
> Fix For: 0.19
>
>
> Older versions of the Java Broker (0.5) used to close the connection in the event of transaction time (on detection of open or idle transaction) rather than close the session. When the transaction timeout feature was forward ported to 0.11, the decision was made to close the session for both 0-10 and 0-8...0-9-1. Unfortunately the Java client does not handle the session close correctly and this results in a connection leak.
> This change will revert the 0-8...0-9-1 code paths within the Java Broker to use connection close rather than session close. This will ensure that the Java Broker remains compatibility with Java Clients that suffer this problem..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Resolved] (QPID-4131) Broker should close connection on
transaction timeout rather than close session for better compatibility with
Java clients
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey resolved QPID-4131.
---------------------------------
Resolution: Fixed
Looks good to me. I tested this by repeatedly causing transactions to time out, and used JConsole to observe the corresponding connections disappearing.
> Broker should close connection on transaction timeout rather than close session for better compatibility with Java clients
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-4131
> URL: https://issues.apache.org/jira/browse/QPID-4131
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.12, 0.14, 0.16, 0.18
> Reporter: Keith Wall
> Assignee: Philip Harvey
> Fix For: 0.19
>
>
> Older versions of the Java Broker (0.5) used to close the connection in the event of transaction time (on detection of open or idle transaction) rather than close the session. When the transaction timeout feature was forward ported to 0.11, the decision was made to close the session for both 0-10 and 0-8...0-9-1. Unfortunately the Java client does not handle the session close correctly and this results in a connection leak.
> This change will revert the 0-8...0-9-1 code paths within the Java Broker to use connection close rather than session close. This will ensure that the Java Broker remains compatibility with Java Clients that suffer this problem..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4131) Broker should close connection on
transaction timeout rather than close session for better compatibility with
Java clients
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4131:
-----------------------------
Status: Ready To Review (was: In Progress)
> Broker should close connection on transaction timeout rather than close session for better compatibility with Java clients
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-4131
> URL: https://issues.apache.org/jira/browse/QPID-4131
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.12, 0.14, 0.16, 0.18
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.19
>
>
> Older versions of the Java Broker (0.5) used to close the connection in the event of transaction time (on detection of open or idle transaction) rather than close the session. When the transaction timeout feature was forward ported to 0.11, the decision was made to close the session for both 0-10 and 0-8...0-9-1. Unfortunately the Java client does not handle the session close correctly and this results in a connection leak.
> This change will revert the 0-8...0-9-1 code paths within the Java Broker to use connection close rather than session close. This will ensure that the Java Broker remains compatibility with Java Clients that suffer this problem..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org