You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ti...@apache.org on 2023/08/12 18:06:57 UTC

[tika] 03/04: TIKA-4114: include exception and add dummy throw so that code will with with PDFBox 2.0 and 3.0

This is an automated email from the ASF dual-hosted git repository.

tilman pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git

commit e0b56b321dcb3c380218b43f77a293a79e511012
Author: Tilman Hausherr <ti...@apache.org>
AuthorDate: Sat Aug 12 20:03:37 2023 +0200

    TIKA-4114: include exception and add dummy throw so that code will with with PDFBox 2.0 and 3.0
---
 .../apache/tika/parser/xmp/XMPMetadataExtractor.java  | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-xmp-commons/src/main/java/org/apache/tika/parser/xmp/XMPMetadataExtractor.java b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-xmp-commons/src/main/java/org/apache/tika/parser/xmp/XMPMetadataExtractor.java
index d4a3b4001..157aedb90 100644
--- a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-xmp-commons/src/main/java/org/apache/tika/parser/xmp/XMPMetadataExtractor.java
+++ b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-xmp-commons/src/main/java/org/apache/tika/parser/xmp/XMPMetadataExtractor.java
@@ -32,6 +32,7 @@ import org.apache.tika.metadata.DublinCore;
 import org.apache.tika.metadata.Metadata;
 import org.apache.tika.metadata.Property;
 import org.apache.tika.metadata.XMP;
+import org.apache.xmpbox.type.BadFieldValueException;
 
 /**
  * XMP Metadata Extractor based on Apache XmpBox.
@@ -79,11 +80,19 @@ public class XMPMetadataExtractor {
             return;
         }
         if (schemaDublinCore != null) {
-            addMetadata(metadata, DublinCore.TITLE, schemaDublinCore.getTitle());
-            addMetadata(metadata, DublinCore.FORMAT, schemaDublinCore.getFormat());
-            addMetadata(metadata, DublinCore.DESCRIPTION, schemaDublinCore.getDescription());
-            addMetadata(metadata, DublinCore.CREATOR, schemaDublinCore.getCreators());
-            addMetadata(metadata, DublinCore.SUBJECT, schemaDublinCore.getSubjects());
+            try {
+                addMetadata(metadata, DublinCore.TITLE, schemaDublinCore.getTitle());
+                addMetadata(metadata, DublinCore.FORMAT, schemaDublinCore.getFormat());
+                addMetadata(metadata, DublinCore.DESCRIPTION, schemaDublinCore.getDescription());
+                addMetadata(metadata, DublinCore.CREATOR, schemaDublinCore.getCreators());
+                addMetadata(metadata, DublinCore.SUBJECT, schemaDublinCore.getSubjects());
+                //TODO PDFBOX30 this segment no longer needed with 3.0
+                if (false != false)
+                    throw new BadFieldValueException("");
+            }
+            catch (BadFieldValueException ex) {
+                throw new IOException(ex);
+            }
         }
     }