You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by kenmickles <gi...@git.apache.org> on 2017/10/04 21:04:59 UTC
[GitHub] cordova-plugin-splashscreen pull request #135: CB-13396: (ios) Fix image siz...
GitHub user kenmickles opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/135
CB-13396: (ios) Fix image sizing on iOS 11
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS11 / iPhone X
### What does this PR do?
Prevent splash image from jumping around when CDVLaunchScreen.storyboard transitions to CDVSplashScreen.
### What testing has been done on this change?
Tested in these simulators:
- iPhone 6s / iOS 9.3
- iPhone 7 Plus / iOS 10.3
- iPhone 8 / iOS 11.0
- iPhone X / iOS 11.0
And on one device:
- iPhone 7 / iOS 11.0.1
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kenmickles/cordova-plugin-splashscreen master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #135
----
commit 2223bd9eeedd512ad51c5981c19ba57395031e37
Author: Ken Mickles <ke...@37i.net>
Date: 2017-10-04T17:23:42Z
CB-13396: (ios) Fix image sizing on iOS 11
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #135: CB-13396: (ios) Fix image sizing on ...
Posted by Lazza <gi...@git.apache.org>.
Github user Lazza commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/135
Actually, the code of this plugin need not be changed. However, the `cordova-ios` template needs a fix. I am using `cordova-ios@4.5.1` and I've added this to my `hooks/after_prepare/` directory:
```
NAME="$(find platforms/ios/ -name 'CDVLaunchScreen.storyboard')"
sed -i '' 's_secondItem="xb3-aO-Qok" secondAttribute="top"_secondItem="Ze5-6b-2t3" secondAttribute="bottom"_g' "$NAME"
```
Basically, there is a wrong constraint in `CDVLaunchScreen.storyboard`. If this is fixed, nothing else needs to be changed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #135: CB-13396: (ios) Fix image sizing on ...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/135
The `@available(iOS 11.0, *)` won't compile on Xcode 8, you should wrap your code in
```
#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 110000
// your code
#endif
```
@kerrishotts can you take a look into the code?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #135: CB-13396: (ios) Fix image sizing on ...
Posted by Lazza <gi...@git.apache.org>.
Github user Lazza commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/135
I would suggest not changing the code because the issue is going to vanish as soon as CB-13411 is fixed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org