You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2020/07/14 16:26:28 UTC
[lucene-solr] 01/02: #144 - Fix this test.
This is an automated email from the ASF dual-hosted git repository.
markrmiller pushed a commit to branch reference_impl
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
commit eeb3bfc1757e51838265fc57f32db95fed39efa0
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Tue Jul 14 11:24:42 2020 -0500
#144 - Fix this test.
---
.../solrj/routing/ReplicaListTransformerTest.java | 24 ++++++++++++++--------
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/solr/solrj/src/test/org/apache/solr/client/solrj/routing/ReplicaListTransformerTest.java b/solr/solrj/src/test/org/apache/solr/client/solrj/routing/ReplicaListTransformerTest.java
index 75afe70..ad33a18 100644
--- a/solr/solrj/src/test/org/apache/solr/client/solrj/routing/ReplicaListTransformerTest.java
+++ b/solr/solrj/src/test/org/apache/solr/client/solrj/routing/ReplicaListTransformerTest.java
@@ -25,6 +25,7 @@ import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
+import java.util.concurrent.atomic.AtomicReference;
import org.apache.solr.SolrTestCase;
import org.apache.solr.common.cloud.Replica;
@@ -106,16 +107,20 @@ public class ReplicaListTransformerTest extends SolrTestCase {
final String regex = ".*" + random().nextInt(10) + ".*";
- ReplicaListTransformer transformer = null;
+ AtomicReference<ReplicaListTransformer> transformer = new AtomicReference<>();
try {
if (random().nextBoolean()) {
log.info("Using ToyMatching Transfomer");
- transformer = new ToyMatchingReplicaListTransformer(regex);
+ transformer.set(new ToyMatchingReplicaListTransformer(regex));
} else {
log.info("Using conditional Transfomer");
- transformer = new HttpShardHandlerFactory() {
-
+ try (HttpShardHandlerFactory hsh = new HttpShardHandlerFactory() {
+ {
+ transformer.set(getReplicaListTransformer(
+ new LocalSolrQueryRequest(null,
+ new ModifiableSolrParams().add("toyRegEx", regex))));
+ }
@Override
protected ReplicaListTransformer getReplicaListTransformer(final SolrQueryRequest req) {
final SolrParams params = req.getParams();
@@ -132,9 +137,10 @@ public class ReplicaListTransformerTest extends SolrTestCase {
return super.getReplicaListTransformer(req);
}
- }.getReplicaListTransformer(
- new LocalSolrQueryRequest(null,
- new ModifiableSolrParams().add("toyRegEx", regex)));
+ };) {
+
+ }
+
}
final List<Replica> inputs = new ArrayList<>();
@@ -167,12 +173,12 @@ public class ReplicaListTransformerTest extends SolrTestCase {
}
final List<Replica> actualTransformed = new ArrayList<>(inputs);
- transformer.transform(actualTransformed);
+ transformer.get().transform(actualTransformed);
assertEquals(expectedTransformed, actualTransformed);
} finally {
if (transformer != null) {
- transformer.close();
+ transformer.get().close();
}
}
}