[GitHub] [flink] XComp commented on a diff in pull request #22774: [FLINK-32329][tests] Do not override env.java.opts.all

["XComp (via GitHub)" <gi...@apache.org>]

XComp commented on code in PR #22774:
URL: https://github.com/apache/flink/pull/22774#discussion_r1228487316


##########
flink-end-to-end-tests/test-scripts/test_ha_datastream.sh:
##########
@@ -45,7 +45,8 @@ function run_ha_test() {
     # change the pid dir to start log files always from 0, this is important for checks in the
     # jm killing loop
     set_config_key "env.pid.dir" "${TEST_DATA_DIR}"
-    set_config_key "env.java.opts.all" "-ea"
+    set_config_key "env.java.opts.jm" "-ea"
+    set_config_key "env.java.opts.tm" "-ea"

Review Comment:
   There are no occurrences for `env.java.opts.jm` and `env.java.opts.tm` in the code. There are `env.java.opts.jobmanager` and `env.java.opts.taskmanager` in `flink-dist/src/main/flink-bin/bin/config.sh`, though. :thinking:  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org