You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/09/30 08:53:00 UTC
[jira] [Commented] (AIRFLOW-5280) aws_default's region_name
defaults to us-east-1 which causes major confusion for connections that do
not use this region
[ https://issues.apache.org/jira/browse/AIRFLOW-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940760#comment-16940760 ]
ASF subversion and git services commented on AIRFLOW-5280:
----------------------------------------------------------
Commit 781d0018636b7cc21367141605a113cc47896c01 in airflow's branch refs/heads/master from Marek Šuppa
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=781d001 ]
[AIRFLOW-5280] conn: Remove aws_default's default region name (#5879)
The `aws_default` by default specifies the `region_name` to be
`us-east-1` in its `extra` field. This causes trouble when the desired
AWS account uses a different region as this default value has priority
over the $AWS_REGION and $AWS_DEFAULT_REGION environment variables,
gets passed directly to `botocore` and does not seem to be documented.
This commit removes the default region name from the `aws_default`'s
extra field. This means that it will have to be set manually, which
would follow the "explicit is better than implicit" philosophy.
> aws_default's region_name defaults to us-east-1 which causes major confusion for connections that do not use this region
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: AIRFLOW-5280
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5280
> Project: Apache Airflow
> Issue Type: Improvement
> Components: aws
> Affects Versions: 1.10.4
> Reporter: Marek Suppa
> Assignee: Marek Suppa
> Priority: Minor
>
> The `aws_default` by default specifies the `region_name` to be
> `us-east-1` in its `extra` field. This causes trouble when the desired
> AWS account uses a different region as this default value has priority
> over the $AWS_REGION and $AWS_DEFAULT_REGION environment variables,
> gets passed directly to `botocore` and does not seem to be documented.
> It seems that the best way of dealing with this situation would be to remove this default variable. The result of this would be that all aws_default connection parameters would have to manually define it which seems to be consistent with "explicit better than implicit" philosophy.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)