You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/15 15:48:44 UTC

[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #4126: Spark: Close executor services after action completes in Procedures

RussellSpitzer commented on a change in pull request #4126:
URL: https://github.com/apache/iceberg/pull/4126#discussion_r806987049



##########
File path: spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/BaseProcedure.java
##########
@@ -151,4 +161,25 @@ TableCatalog tableCatalog() {
       return tableCatalog;
     }
   }
+
+  /**
+   * Closes the procedure's executor service if a new one was created.
+   */
+  protected void closeService() {
+    if (executorService != null) {
+      executorService.shutdown();
+    }
+  }
+
+  protected ExecutorService executorService(int concurrentDeletes, String nameFormat) {
+    Preconditions.checkArgument(executorService == null, "Cannot create a new executor service, one already exists.");
+    executorService = MoreExecutors.getExitingExecutorService(
+        (ThreadPoolExecutor) Executors.newFixedThreadPool(
+            concurrentDeletes,
+            new ThreadFactoryBuilder()
+                .setNameFormat(nameFormat + "-%d")

Review comment:
       Sure I can protect against that, this is an internal method so i'm not that worried.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org