Re: svn commit: r21716 - trunk/subversion/svnadmin

[Philip Martin <ph...@codematters.co.uk>]

dlr@tigris.org writes:

> Author: dlr
> Date: Fri Sep 29 10:51:08 2006
> New Revision: 21716
>
> Log:
> * subversion/svnadmin/main.c
>   (cmd_table): Improve wording of help for the "setlog" command.
>
>
> Modified:
>    trunk/subversion/svnadmin/main.c
>
> Modified: trunk/subversion/svnadmin/main.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/svnadmin/main.c?pathrev=21716&r1=21715&r2=21716
> ==============================================================================
> --- trunk/subversion/svnadmin/main.c	(original)
> +++ trunk/subversion/svnadmin/main.c	Fri Sep 29 10:51:08 2006
> @@ -394,8 +394,9 @@
>      "from your post-revprop-change hook, or because the modification of\n"
>      "revision properties has not been enabled in the pre-revprop-change\n"
>      "hook).\n\n"
> -    "NOTE: revision properties are not historied, so this command\n"
> -    "will permanently overwrite the previous log message.\n"),
> +    "NOTE: Revision properties are not versioned (e.g. no revision history\n"
> +    "is maintained), so this command will permanently overwrite the previous\n"
> +    "log message.\n"),

'e.g.' doesn't quite read correctly there, perhaps you should use
'i.e'?  But really I think we should assume the user knows what
versioned means and drop the () clause.  It's not really 'permanent'
either :)

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r21716 - trunk/subversion/svnadmin

[Daniel Rall <dl...@collab.net>]

On Fri, 06 Oct 2006, Daniel Rall wrote:

> On Fri, 06 Oct 2006, Philip Martin wrote:
...
> > 'e.g.' doesn't quite read correctly there, perhaps you should use
> > 'i.e'?  But really I think we should assume the user knows what
> > versioned means and drop the () clause.  It's not really 'permanent'
> > either :)
> 
> Thanks Philip.  How's this?
...

Committed in r21850.

Re: svn commit: r21716 - trunk/subversion/svnadmin

[Daniel Rall <dl...@collab.net>]

On Fri, 06 Oct 2006, Philip Martin wrote:
...
> > --- trunk/subversion/svnadmin/main.c	(original)
> > +++ trunk/subversion/svnadmin/main.c	Fri Sep 29 10:51:08 2006
> > @@ -394,8 +394,9 @@
> >      "from your post-revprop-change hook, or because the modification of\n"
> >      "revision properties has not been enabled in the pre-revprop-change\n"
> >      "hook).\n\n"
> > -    "NOTE: revision properties are not historied, so this command\n"
> > -    "will permanently overwrite the previous log message.\n"),
> > +    "NOTE: Revision properties are not versioned (e.g. no revision history\n"
> > +    "is maintained), so this command will permanently overwrite the previous\n"
> > +    "log message.\n"),
> 
> 'e.g.' doesn't quite read correctly there, perhaps you should use
> 'i.e'?  But really I think we should assume the user knows what
> versioned means and drop the () clause.  It's not really 'permanent'
> either :)

Thanks Philip.  How's this?

Index: subversion/svnadmin/main.c
===================================================================
--- subversion/svnadmin/main.c	(revision 21818)
+++ subversion/svnadmin/main.c	(working copy)
@@ -403,9 +403,8 @@
     "from your post-revprop-change hook, or because the modification of\n"
     "revision properties has not been enabled in the pre-revprop-change\n"
     "hook).\n\n"
-    "NOTE: Revision properties are not versioned (e.g. no revision history\n"
-    "is maintained), so this command will permanently overwrite the previous\n"
-    "log message.\n"),
+    "NOTE: Revision properties are not versioned, so this command will\n"
+    "overwrite the previous log message.\n"),
    {'r', svnadmin__bypass_hooks} },
 
   {"setrevprop", subcommand_setrevprop, {0}, N_
@@ -414,9 +413,8 @@
     "--use-pre-revprop-change-hook/--use-post-revprop-change-hook to trigger\n"
     "the revision property-related hooks (for example, if you want an email\n"
     "notification sent from your post-revprop-change hook).\n\n"
-    "NOTE: Revision properties are not versioned (e.g. no revision history\n"
-    "is maintained), so this command will permanently overwrite the previous\n"
-    "value for the property.\n"),
+    "NOTE: Revision properties are not versioned, so this command will\n"
+    "overwrite the previous value of the property.\n"),
    {'r', svnadmin__use_pre_revprop_change_hook,
     svnadmin__use_post_revprop_change_hook} },