You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2018/11/19 17:18:59 UTC

[GitHub] nwangtw commented on a change in pull request #3112: [Java Streamlet API] Support abstractions on Streamlet Operators

nwangtw commented on a change in pull request #3112: [Java Streamlet API] Support abstractions on Streamlet Operators
URL: https://github.com/apache/incubator-heron/pull/3112#discussion_r234708248
 
 

 ##########
 File path: heron/api/src/java/org/apache/heron/streamlet/impl/operators/TransformOperator.java
 ##########
 @@ -41,10 +40,10 @@
  */
 public class TransformOperator<R, T> extends StreamletOperator<R, T>
     implements IStatefulComponent<Serializable, Serializable> {
+
   private static final long serialVersionUID = 429297144878185182L;
   private SerializableTransformer<? super R, ? extends T> serializableTransformer;
 
-  private OutputCollector collector;
 
 Review comment:
   I am thinking in the prepare() function, instead of setting collector direction, it might be better to call super.prepare(...) instead. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services