You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by ao...@apache.org on 2021/03/31 22:49:34 UTC

[iceberg] branch master updated: Spark: Add override annotations to rewrite manifests action (#2401)

This is an automated email from the ASF dual-hosted git repository.

aokolnychyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new 3e177b4  Spark: Add override annotations to rewrite manifests action (#2401)
3e177b4 is described below

commit 3e177b4adcda33f55d9804be663640cf0234e23d
Author: Anton Okolnychyi <ao...@apple.com>
AuthorDate: Wed Mar 31 15:49:23 2021 -0700

    Spark: Add override annotations to rewrite manifests action (#2401)
---
 .../spark/actions/BaseRewriteManifestsSparkAction.java    | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteManifestsSparkAction.java b/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteManifestsSparkAction.java
index 8e9f722..1a1cb6f 100644
--- a/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteManifestsSparkAction.java
+++ b/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteManifestsSparkAction.java
@@ -121,29 +121,20 @@ public class BaseRewriteManifestsSparkAction
     return this;
   }
 
+  @Override
   public RewriteManifests specId(int specId) {
     Preconditions.checkArgument(table.specs().containsKey(specId), "Invalid spec id %d", specId);
     this.spec = table.specs().get(specId);
     return this;
   }
 
-  /**
-   * Rewrites only manifests that match the given predicate.
-   *
-   * @param newPredicate a predicate
-   * @return this for method chaining
-   */
+  @Override
   public RewriteManifests rewriteIf(Predicate<ManifestFile> newPredicate) {
     this.predicate = newPredicate;
     return this;
   }
 
-  /**
-   * Passes a location where the manifests should be written.
-   *
-   * @param newStagingLocation a staging location
-   * @return this for method chaining
-   */
+  @Override
   public RewriteManifests stagingLocation(String newStagingLocation) {
     this.stagingLocation = newStagingLocation;
     return this;