You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by sp...@caseyconnor.org on 2009/08/21 00:49:02 UTC
jSPF nit
Hi - maybe this is on the picky side, feel free to say so, but:
org.apache.james.jspf.impl.DNSServiceXBillImpl.java - line 158-160, at
least in rev 801912:
if (queryResult == Lookup.TRY_AGAIN) {
throw new TimeoutException(query.getErrorString());
}
...i'm basically ignorant of the finer points of all this, but doesn't
org.xbill.DNS.Lookup return TRY_AGAIN for a variety of reasons (e.g. not
just Timeouts) which would deserve potentially different
exceptions/logging? from Lookup.java:
531 if (badresponse) {
532 result = TRY_AGAIN;
533 error = badresponse_error;
534 done = true;
535 } else if (timedout) {
536 result = TRY_AGAIN;
537 error = "timed out";
538 done = true;
539 } else if (networkerror) {
540 result = TRY_AGAIN;
541 error = "network error";
542 done = true;
...we were seeing "timeouts" from jSPF in our logs that were happening
in <20ms, so we believe we're having other net issues in reality.
Thanks!
-Casey
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: jSPF nit
Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Wed, Aug 26, 2009 at 10:03 PM, <sp...@caseyconnor.org> wrote:
> Opened as JSPF-83... I only had/have time to submit a kind of paltry
> recommendation, but hopefully it helps. Thanks!
every little helps :-)
thanks
- robert
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: jSPF nit
Posted by sp...@caseyconnor.org.
Opened as JSPF-83... I only had/have time to submit a kind of paltry
recommendation, but hopefully it helps. Thanks!
-Casey
Robert Burrell Donkin wrote:
> On Thu, Aug 20, 2009 at 11:49 PM, <sp...@caseyconnor.org> wrote:
>
>> Hi - maybe this is on the picky side, feel free to say so, but:
>>
>> org.apache.james.jspf.impl.DNSServiceXBillImpl.java - line 158-160, at least
>> in rev 801912:
>>
>> if (queryResult == Lookup.TRY_AGAIN) {
>> throw new TimeoutException(query.getErrorString());
>> }
>>
>> ...i'm basically ignorant of the finer points of all this, but doesn't
>> org.xbill.DNS.Lookup return TRY_AGAIN for a variety of reasons (e.g. not
>> just Timeouts) which would deserve potentially different exceptions/logging?
>> from Lookup.java:
>>
>> 531 if (badresponse) {
>> 532 result = TRY_AGAIN;
>> 533 error = badresponse_error;
>> 534 done = true;
>> 535 } else if (timedout) {
>> 536 result = TRY_AGAIN;
>> 537 error = "timed out";
>> 538 done = true;
>> 539 } else if (networkerror) {
>> 540 result = TRY_AGAIN;
>> 541 error = "network error";
>> 542 done = true;
>>
>>
>> ...we were seeing "timeouts" from jSPF in our logs that were happening in
>> <20ms, so we believe we're having other net issues in reality.
>>
>
> sounds about right - could you open a JIRA (issues.apache.org/jira)
> and contribute a suggested patch?
>
> cheers
>
> - robert
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>
Re: jSPF nit
Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Thu, Aug 20, 2009 at 11:49 PM, <sp...@caseyconnor.org> wrote:
> Hi - maybe this is on the picky side, feel free to say so, but:
>
> org.apache.james.jspf.impl.DNSServiceXBillImpl.java - line 158-160, at least
> in rev 801912:
>
> if (queryResult == Lookup.TRY_AGAIN) {
> throw new TimeoutException(query.getErrorString());
> }
>
> ...i'm basically ignorant of the finer points of all this, but doesn't
> org.xbill.DNS.Lookup return TRY_AGAIN for a variety of reasons (e.g. not
> just Timeouts) which would deserve potentially different exceptions/logging?
> from Lookup.java:
>
> 531 if (badresponse) {
> 532 result = TRY_AGAIN;
> 533 error = badresponse_error;
> 534 done = true;
> 535 } else if (timedout) {
> 536 result = TRY_AGAIN;
> 537 error = "timed out";
> 538 done = true;
> 539 } else if (networkerror) {
> 540 result = TRY_AGAIN;
> 541 error = "network error";
> 542 done = true;
>
>
> ...we were seeing "timeouts" from jSPF in our logs that were happening in
> <20ms, so we believe we're having other net issues in reality.
sounds about right - could you open a JIRA (issues.apache.org/jira)
and contribute a suggested patch?
cheers
- robert
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org