[jira] [Commented] (MAPREDUCE-6121) JobResourceUpdater#compareFs() doesn't handle HA namespaces

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609190#comment-14609190 ] 

Hadoop QA commented on MAPREDUCE-6121:
--------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  16m  6s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| {color:red}-1{color} | javac |   4m  4s | The patch appears to cause the build to fail. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12742950/MAPREDUCE-6121.003.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 9ee7b6e |
| Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5866/console |


This message was automatically generated.

> JobResourceUpdater#compareFs() doesn't handle HA namespaces
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-6121
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6121
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 2.5.0
>            Reporter: Thomas Graves
>            Assignee: Ray Chiang
>         Attachments: MAPREDUCE-6121.001.patch, MAPREDUCE-6121.002.patch, MAPREDUCE-6121.003.patch
>
>
> Looking at the JobSubmitter.compareFs it doesn't look like it properly handles HA namespaces.  The code tries to lookup the hostname using InetAddress.getByName, but if you are using namespaces this is going to fail and its going to copy the file when it doesn't need to. 
> Edit: JobSubmitter was updated to JobResourceUpdater in MAPREDUCE-6267.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)