You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/07/21 02:55:41 UTC
[kudu-CR] WIP [tserver] support strong consisitency read from followers
Yuqi Du has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18766
Change subject: WIP [tserver] support strong consisitency read from followers
......................................................................
WIP [tserver] support strong consisitency read from followers
Java client has supported LeaderOnly and Closest Replica selective
stretegy. Closest Replica can reduce brandwidth cost but exist
consistency problem.
The patch support strong consisitency read, read followers just like
read leaders by anther request(GetLastOpIdRequestPB) to leader and
get the last committed opid at leader, and wait local replica reach
the opid, and then start read data.
Change-Id: If273c89db2185813e7f4507871be75a4af7d5e29
---
M src/kudu/common/common.proto
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver.proto
8 files changed, 111 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/18766/1
--
To view, visit http://gerrit.cloudera.org:8080/18766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If273c89db2185813e7f4507871be75a4af7d5e29
Gerrit-Change-Number: 18766
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
[kudu-CR] WIP [tserver] KUDU-3382 support strong consisitency read from followers
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18766
to look at the new patch set (#5).
Change subject: WIP [tserver] KUDU-3382 support strong consisitency read from followers
......................................................................
WIP [tserver] KUDU-3382 support strong consisitency read from followers
Java client has supported LeaderOnly and Closest Replica selective
stretegy. Closest Replica can reduce brandwidth cost but exist
consistency problem.
The patch support strong consisitency read, read followers just like
read leaders by anther request(GetLastOpIdRequestPB) to leader and
get the last committed opid at leader, and wait local replica reach
the opid, and then start read data.
Change-Id: If273c89db2185813e7f4507871be75a4af7d5e29
---
M src/kudu/common/common.proto
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/master.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica-test-base.h
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/tserver.proto
18 files changed, 200 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/18766/5
--
To view, visit http://gerrit.cloudera.org:8080/18766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If273c89db2185813e7f4507871be75a4af7d5e29
Gerrit-Change-Number: 18766
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] WIP [tserver] support strong consisitency read from followers
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18766 )
Change subject: WIP [tserver] support strong consisitency read from followers
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/18766/1/src/kudu/consensus/consensus_peers.h
File src/kudu/consensus/consensus_peers.h:
http://gerrit.cloudera.org:8080/#/c/18766/1/src/kudu/consensus/consensus_peers.h@258
PS1, Line 258: virtual void GetLastOpId(const GetLastOpIdRequestPB& /* request */,
> warning: parameter 'request' is unused [misc-unused-parameters]
Done
http://gerrit.cloudera.org:8080/#/c/18766/1/src/kudu/consensus/consensus_peers.h@259
PS1, Line 259: GetLastOpIdResponsePB* /* response */,
> warning: parameter 'response' is unused [misc-unused-parameters]
Done
http://gerrit.cloudera.org:8080/#/c/18766/1/src/kudu/consensus/consensus_peers.h@260
PS1, Line 260: rpc::RpcController* /* controller */) {
> warning: parameter 'controller' is unused [misc-unused-parameters]
Done
--
To view, visit http://gerrit.cloudera.org:8080/18766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If273c89db2185813e7f4507871be75a4af7d5e29
Gerrit-Change-Number: 18766
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 08:23:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] WIP [tserver] KUDU-3382 support strong consisitency read from followers
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18766
to look at the new patch set (#4).
Change subject: WIP [tserver] KUDU-3382 support strong consisitency read from followers
......................................................................
WIP [tserver] KUDU-3382 support strong consisitency read from followers
Java client has supported LeaderOnly and Closest Replica selective
stretegy. Closest Replica can reduce brandwidth cost but exist
consistency problem.
The patch support strong consisitency read, read followers just like
read leaders by anther request(GetLastOpIdRequestPB) to leader and
get the last committed opid at leader, and wait local replica reach
the opid, and then start read data.
Change-Id: If273c89db2185813e7f4507871be75a4af7d5e29
---
M src/kudu/common/common.proto
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/kserver/kserver.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/master.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/tserver.proto
14 files changed, 173 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/18766/4
--
To view, visit http://gerrit.cloudera.org:8080/18766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If273c89db2185813e7f4507871be75a4af7d5e29
Gerrit-Change-Number: 18766
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] WIP [tserver] support strong consisitency read from followers
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18766
to look at the new patch set (#2).
Change subject: WIP [tserver] support strong consisitency read from followers
......................................................................
WIP [tserver] support strong consisitency read from followers
Java client has supported LeaderOnly and Closest Replica selective
stretegy. Closest Replica can reduce brandwidth cost but exist
consistency problem.
The patch support strong consisitency read, read followers just like
read leaders by anther request(GetLastOpIdRequestPB) to leader and
get the last committed opid at leader, and wait local replica reach
the opid, and then start read data.
Change-Id: If273c89db2185813e7f4507871be75a4af7d5e29
---
M src/kudu/common/common.proto
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/master/sys_catalog.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_server.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/tserver.proto
12 files changed, 167 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/18766/2
--
To view, visit http://gerrit.cloudera.org:8080/18766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If273c89db2185813e7f4507871be75a4af7d5e29
Gerrit-Change-Number: 18766
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] WIP [tserver] support strong consisitency read from followers
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18766
to look at the new patch set (#3).
Change subject: WIP [tserver] support strong consisitency read from followers
......................................................................
WIP [tserver] support strong consisitency read from followers
Java client has supported LeaderOnly and Closest Replica selective
stretegy. Closest Replica can reduce brandwidth cost but exist
consistency problem.
The patch support strong consisitency read, read followers just like
read leaders by anther request(GetLastOpIdRequestPB) to leader and
get the last committed opid at leader, and wait local replica reach
the opid, and then start read data.
Change-Id: If273c89db2185813e7f4507871be75a4af7d5e29
---
M src/kudu/common/common.proto
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/master/sys_catalog.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_server.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/tserver.proto
12 files changed, 173 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/18766/3
--
To view, visit http://gerrit.cloudera.org:8080/18766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If273c89db2185813e7f4507871be75a4af7d5e29
Gerrit-Change-Number: 18766
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>