You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2020/03/30 19:21:51 UTC

[kudu-CR] [util] Add special handling for nullptr in fast hash

Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15600


Change subject: [util] Add special handling for nullptr in fast hash
......................................................................

[util] Add special handling for nullptr in fast hash

Importing special handling for nullptr from Impala that helps distinguish
between nullptr with possibly non-zero length input and empty object.
https://github.com/apache/impala/blob/master/be/src/runtime/raw-value.inline.h#L40

Fast hash already handles zero-length input and hence no special handling
for zero length input.

Fast hash is currently only used for BlockBloomFilter and hence no backward
compatibility concerns. Don't plan to use Murmur2 hash with BlockBloomFilter
and hence not importing the same logic for Murmur2 or other hash functions.
Importing the same logic for other hash functions will require taking backward
compatibilty into account.

Additionally this change updates Java implementation of Fast hash
to drop the explicit "len" parameter as arrays in Java include length.

Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
---
M java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestFashHash.java
M src/kudu/util/hash_util-test.cc
M src/kudu/util/hash_util.h
4 files changed, 72 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/15600/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
Gerrit-Change-Number: 15600
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>

[kudu-CR] [util] Add special handling for nullptr in fast hash

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15600 )

Change subject: [util] Add special handling for nullptr in fast hash
......................................................................

[util] Add special handling for nullptr in fast hash

Importing special handling for nullptr from Impala that helps distinguish
between nullptr with possibly non-zero length input and empty object.
https://github.com/apache/impala/blob/master/be/src/runtime/raw-value.inline.h#L40
https://github.com/apache/impala/blob/master/be/src/runtime/raw-value-ir.cc#L179

Fast hash already handles zero-length input and hence no special handling
for zero length input.

Fast hash is currently only used for BlockBloomFilter and hence no backward
compatibility concerns. Don't plan to use Murmur2 hash with BlockBloomFilter
and hence not importing the same logic for Murmur2 or other hash functions.
Importing the same logic for other hash functions will require taking backward
compatibility into account.

Additionally this change updates Java implementation of Fast hash
to drop the explicit "len" parameter as arrays in Java include length.

Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
Reviewed-on: http://gerrit.cloudera.org:8080/15600
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestFashHash.java
M src/kudu/util/hash_util-test.cc
M src/kudu/util/hash_util.h
4 files changed, 79 insertions(+), 14 deletions(-)

Approvals:
  Wenzhe Zhou: Looks good to me, but someone else must approve
  Adar Dembo: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
Gerrit-Change-Number: 15600
Gerrit-PatchSet: 4
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[kudu-CR] [util] Add special handling for nullptr in fast hash

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 )

Change subject: [util] Add special handling for nullptr in fast hash
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/15600/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15600/1//COMMIT_MSG@20
PS1, Line 20: compatibilty
> compatibility
Done


http://gerrit.cloudera.org:8080/#/c/15600/1/java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java:

http://gerrit.cloudera.org:8080/#/c/15600/1/java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java@a92
PS1, Line 92: 
> Perhaps the intent was to allow computing the hash on a slice of the array 
That wasn't the intent. Had that been the case, there would have been validation "len <= buf.length" which is missing.


http://gerrit.cloudera.org:8080/#/c/15600/1/java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java@24
PS1, Line 24:   // Constant imported from Apache Impala used to compute hash values for special cases.
            :   // Constant obtained by taking lower bytes of generated UUID.
> 1. What's the "generated UUID" you're alluding to?
This is the UUID that was once generated in Impala. 2nd line taken straight from Impala source. 1st line mentions about the import from Impala.

> 2. Is it important that this value matches the value in Apache Impala? If so, why?
Yes.
Impala will use the direct BlockBloomFilter API and insert hash value directly using it's own existing implementation of the fast hash. Hence the value must match with Impala.
https://github.com/apache/impala/blob/master/be/src/runtime/raw-value-ir.cc#L179


http://gerrit.cloudera.org:8080/#/c/15600/1/src/kudu/util/hash_util.h
File src/kudu/util/hash_util.h:

http://gerrit.cloudera.org:8080/#/c/15600/1/src/kudu/util/hash_util.h@32
PS1, Line 32: // Constant imported from Apache Impala used to compute hash values for special cases.
> If you end up changing the comment in the Java code to reflect my questions
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/15600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
Gerrit-Change-Number: 15600
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Mar 2020 22:41:17 +0000
Gerrit-HasComments: Yes

[kudu-CR] [util] Add special handling for nullptr in fast hash

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/15600 )

Change subject: [util] Add special handling for nullptr in fast hash
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/15600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
Gerrit-Change-Number: 15600
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[kudu-CR] [util] Add special handling for nullptr in fast hash

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Wenzhe Zhou, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15600

to look at the new patch set (#2).

Change subject: [util] Add special handling for nullptr in fast hash
......................................................................

[util] Add special handling for nullptr in fast hash

Importing special handling for nullptr from Impala that helps distinguish
between nullptr with possibly non-zero length input and empty object.
https://github.com/apache/impala/blob/master/be/src/runtime/raw-value.inline.h#L40
https://github.com/apache/impala/blob/master/be/src/runtime/raw-value-ir.cc#L179

Fast hash already handles zero-length input and hence no special handling
for zero length input.

Fast hash is currently only used for BlockBloomFilter and hence no backward
compatibility concerns. Don't plan to use Murmur2 hash with BlockBloomFilter
and hence not importing the same logic for Murmur2 or other hash functions.
Importing the same logic for other hash functions will require taking backward
compatibility into account.

Additionally this change updates Java implementation of Fast hash
to drop the explicit "len" parameter as arrays in Java include length.

Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
---
M java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestFashHash.java
M src/kudu/util/hash_util-test.cc
M src/kudu/util/hash_util.h
4 files changed, 72 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/15600/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
Gerrit-Change-Number: 15600
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[kudu-CR] [util] Add special handling for nullptr in fast hash

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Wenzhe Zhou, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15600

to look at the new patch set (#3).

Change subject: [util] Add special handling for nullptr in fast hash
......................................................................

[util] Add special handling for nullptr in fast hash

Importing special handling for nullptr from Impala that helps distinguish
between nullptr with possibly non-zero length input and empty object.
https://github.com/apache/impala/blob/master/be/src/runtime/raw-value.inline.h#L40
https://github.com/apache/impala/blob/master/be/src/runtime/raw-value-ir.cc#L179

Fast hash already handles zero-length input and hence no special handling
for zero length input.

Fast hash is currently only used for BlockBloomFilter and hence no backward
compatibility concerns. Don't plan to use Murmur2 hash with BlockBloomFilter
and hence not importing the same logic for Murmur2 or other hash functions.
Importing the same logic for other hash functions will require taking backward
compatibility into account.

Additionally this change updates Java implementation of Fast hash
to drop the explicit "len" parameter as arrays in Java include length.

Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
---
M java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestFashHash.java
M src/kudu/util/hash_util-test.cc
M src/kudu/util/hash_util.h
4 files changed, 79 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/15600/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
Gerrit-Change-Number: 15600
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[kudu-CR] [util] Add special handling for nullptr in fast hash

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 )

Change subject: [util] Add special handling for nullptr in fast hash
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
Gerrit-Change-Number: 15600
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Mar 2020 00:30:41 +0000
Gerrit-HasComments: No

[kudu-CR] [util] Add special handling for nullptr in fast hash

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 )

Change subject: [util] Add special handling for nullptr in fast hash
......................................................................


Patch Set 3:

> Patch Set 3: Verified-1
> 
> Build Failed 
> 
> http://jenkins.kudu.apache.org/job/kudu-gerrit/21207/ : FAILURE

Unrelated test failure
DeleteTabletITest.TestLeaderElectionDuringDeleteTablet


-- 
To view, visit http://gerrit.cloudera.org:8080/15600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
Gerrit-Change-Number: 15600
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Mar 2020 00:41:19 +0000
Gerrit-HasComments: No

[kudu-CR] [util] Add special handling for nullptr in fast hash

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 )

Change subject: [util] Add special handling for nullptr in fast hash
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/15600/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15600/1//COMMIT_MSG@20
PS1, Line 20: compatibilty
compatibility


http://gerrit.cloudera.org:8080/#/c/15600/1/java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java:

http://gerrit.cloudera.org:8080/#/c/15600/1/java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java@a92
PS1, Line 92: 
Perhaps the intent was to allow computing the hash on a slice of the array rather than the array in its entirety?

It's mostly academic though: if we never actually used it that way, it doesn't matter.


http://gerrit.cloudera.org:8080/#/c/15600/1/java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java@24
PS1, Line 24:   // Constant imported from Apache Impala used to compute hash values for special cases.
            :   // Constant obtained by taking lower bytes of generated UUID.
Couple things aren't super clear here:
1. What's the "generated UUID" you're alluding to?
2. Is it important that this value matches the value in Apache Impala? If so, why?


http://gerrit.cloudera.org:8080/#/c/15600/1/src/kudu/util/hash_util.h
File src/kudu/util/hash_util.h:

http://gerrit.cloudera.org:8080/#/c/15600/1/src/kudu/util/hash_util.h@32
PS1, Line 32: // Constant imported from Apache Impala used to compute hash values for special cases.
If you end up changing the comment in the Java code to reflect my questions, please update this one too.



-- 
To view, visit http://gerrit.cloudera.org:8080/15600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
Gerrit-Change-Number: 15600
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 30 Mar 2020 20:24:36 +0000
Gerrit-HasComments: Yes

[kudu-CR] [util] Add special handling for nullptr in fast hash

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 )

Change subject: [util] Add special handling for nullptr in fast hash
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15600/1/java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java:

http://gerrit.cloudera.org:8080/#/c/15600/1/java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java@24
PS1, Line 24:   // Constant imported from Apache Impala used to compute hash values for special cases.
            :   // Constant obtained by taking lower bytes of generated UUID.
> > 1. What's the "generated UUID" you're alluding to?
HASH_VAL_NULL is only 4 bytes though, and a UUID is typically 8 bytes. How was this generated? How is it guaranteed to be universally unique?

This comment from Impala's raw-value.inline.h answers my question somewhat:

  /// Arbitrary constants used to compute hash values for special cases. Constants were
  /// obtained by taking lower bytes of generated UUID. NULL and empty strings should
  /// hash to different values.

Could you work some of this information into this comment?

Regarding the importance of the match, could you also work that into the comment?



-- 
To view, visit http://gerrit.cloudera.org:8080/15600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
Gerrit-Change-Number: 15600
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Mar 2020 22:51:43 +0000
Gerrit-HasComments: Yes

[kudu-CR] [util] Add special handling for nullptr in fast hash

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 )

Change subject: [util] Add special handling for nullptr in fast hash
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15600/1/java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java:

http://gerrit.cloudera.org:8080/#/c/15600/1/java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java@a92
PS1, Line 92: 
> That wasn't the intent. Had that been the case, there would have been valid
Ack


http://gerrit.cloudera.org:8080/#/c/15600/1/java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java@24
PS1, Line 24:   // Constant imported from Apache Impala used to compute hash values for special cases.
            :   // Constant obtained by taking lower bytes of generated UUID.
> HASH_VAL_NULL is only 4 bytes though, and a UUID is typically 8 bytes. How 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
Gerrit-Change-Number: 15600
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Mar 2020 00:00:32 +0000
Gerrit-HasComments: Yes

[kudu-CR] [util] Add special handling for nullptr in fast hash

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 )

Change subject: [util] Add special handling for nullptr in fast hash
......................................................................


Patch Set 3: Verified+1 Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316
Gerrit-Change-Number: 15600
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Mar 2020 05:23:46 +0000
Gerrit-HasComments: No