You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/26 15:46:51 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #11222: [BEAM-4150] Don't window PCollection coders.

lukecwik commented on a change in pull request #11222: [BEAM-4150] Don't window PCollection coders.
URL: https://github.com/apache/beam/pull/11222#discussion_r398678099
 
 

 ##########
 File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
 ##########
 @@ -426,7 +423,8 @@ def _collect_written_timers_and_add_to_deferred_inputs(
       pipeline_components,  # type: beam_runner_api_pb2.Components
       stage,  # type: translations.Stage
       bundle_context_manager,  # type: execution.BundleContextManager
-      deferred_inputs  # type: MutableMapping[str, PartitionableBuffer]
+      deferred_inputs,  # type: MutableMapping[str, PartitionableBuffer]
+      data_channel_coders,
 
 Review comment:
   If possible try and keep the typing information on methods.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services