You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "zhaohehuhu (via GitHub)" <gi...@apache.org> on 2023/12/07 08:23:39 UTC
[PR] Kyuubi chat engine supports ernie bot [kyuubi]
zhaohehuhu opened a new pull request, #5828:
URL: https://github.com/apache/kyuubi/pull/5828
# :mag: Description
## Issue References 🔗
<!-- Append the issue number after #. If there is no issue for you to link create one or -->
<!-- If there are no issues to link, please provide details here. -->
This pull request fixes #5386
## Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
## Types of changes :bookmark:
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Test Plan 🧪
#### Behavior Without This Pull Request :coffin:
#### Behavior With This Pull Request :tada:
#### Related Unit Tests
---
# Checklists
## 📝 Author Self Checklist
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [ ] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)
## 📝 Committer Pre-Merge Checklist
- [ ] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested
**Be nice. Be informative.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [CHAT] Kyuubi chat engine supports ernie bot(文心一言) [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5828:
URL: https://github.com/apache/kyuubi/pull/5828#issuecomment-1849220820
Failure is irrelative. Thanks, merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [CHAT] Kyuubi chat engine supports ernie bot(文心一言) [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #5828: [CHAT] Kyuubi chat engine supports ernie bot(文心一言)
URL: https://github.com/apache/kyuubi/pull/5828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [CHAT] Kyuubi chat engine supports ernie bot(文心一言) [kyuubi]
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #5828:
URL: https://github.com/apache/kyuubi/pull/5828#issuecomment-1848442028
Please update the config docs by running `dev/gen/gen_all_config_docs.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Kyuubi chat engine supports ernie bot(文心一言) [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5828:
URL: https://github.com/apache/kyuubi/pull/5828#discussion_r1418639325
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -3056,6 +3059,23 @@ object KyuubiConf {
.stringConf
.createWithDefault("gpt-3.5-turbo")
+ val ERNIE_BOT_ACCESS_TOKEN: OptionalConfigEntry[String] =
+ buildConf("kyuubi.engine.chat.ernie.token")
+ .doc("The token to access ernie bot open API, which could be got at " +
+ "https://cloud.baidu.com/doc/WENXINWORKSHOP/s/Ilkkrb0i5")
+ .version("1.8.0")
Review Comment:
```suggestion
.version("1.9.0")
```
##########
externals/kyuubi-chat-engine/src/main/scala/org/apache/kyuubi/engine/chat/provider/ErnieBotProvider.scala:
##########
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.engine.chat.provider
+
+import java.net.{InetSocketAddress, Proxy, URL}
+import java.time.Duration
+import java.util
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConverters._
+
+import com.google.common.cache.{CacheBuilder, CacheLoader, LoadingCache}
+
+import org.apache.kyuubi.config.KyuubiConf
+import org.apache.kyuubi.engine.chat.ernie.api.ErnieBotApi
+import org.apache.kyuubi.engine.chat.ernie.bean.{ChatCompletionRequest, ChatMessage, ChatMessageRole}
+import org.apache.kyuubi.engine.chat.ernie.service.ErnieBotService
+import org.apache.kyuubi.engine.chat.ernie.service.ErnieBotService.{defaultClient, defaultObjectMapper, defaultRetrofit}
+
+class ErnieBotProvider(conf: KyuubiConf) extends ChatProvider {
+
+ private val accessToken = conf.get(KyuubiConf.ERNIE_BOT_ACCESS_TOKEN).getOrElse {
+ throw new IllegalArgumentException(
+ s"'${KyuubiConf.ERNIE_BOT_ACCESS_TOKEN.key}' must be configured, " +
+ s"which could be got at https://cloud.baidu.com/doc/WENXINWORKSHOP/s/Ilkkrb0i5")
+ }
+
+ private val model = conf.get(KyuubiConf.ERNIE_BOT_MODEL)
+
+ private val ernieBotService: ErnieBotService = {
+ val builder = defaultClient(
+ Duration.ofMillis(conf.get(KyuubiConf.ENGINE_CHAT_GPT_HTTP_SOCKET_TIMEOUT)))
+ .newBuilder
+ .connectTimeout(Duration.ofMillis(conf.get(KyuubiConf.ENGINE_CHAT_GPT_HTTP_CONNECT_TIMEOUT)))
Review Comment:
avoid using configuration starting with `kyuubi.engine.chat.gpt.`
##########
externals/kyuubi-chat-engine/src/main/scala/org/apache/kyuubi/engine/chat/ernie/api/ErnieBotApi.java:
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.engine.chat.ernie.api;
+
+
+import io.reactivex.Single;
+import org.apache.kyuubi.engine.chat.ernie.bean.ChatCompletionRequest;
+import org.apache.kyuubi.engine.chat.ernie.bean.ChatCompletionResult;
+import retrofit2.http.Body;
+import retrofit2.http.POST;
+import retrofit2.http.Query;
+
+public interface ErnieBotApi {
+
+ @POST("/rpc/2.0/ai_custom/v1/wenxinworkshop/chat/completions_pro")
Review Comment:
the "completions_pro" actually looks like a path variable, can we refactor it?
##########
externals/kyuubi-chat-engine/src/main/scala/org/apache/kyuubi/engine/chat/ernie/service/ErnieBotService.java:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.engine.chat.ernie.service;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.PropertyNamingStrategy;
+import io.reactivex.Single;
+import okhttp3.ConnectionPool;
+import okhttp3.OkHttpClient;
+import org.apache.kyuubi.engine.chat.ernie.api.*;
+import org.apache.kyuubi.engine.chat.ernie.bean.ChatCompletionRequest;
+import org.apache.kyuubi.engine.chat.ernie.bean.ChatCompletionResult;
+import org.apache.kyuubi.engine.chat.ernie.constants.Model;
+import retrofit2.HttpException;
+import retrofit2.Retrofit;
+import retrofit2.adapter.rxjava2.RxJava2CallAdapterFactory;
+import retrofit2.converter.jackson.JacksonConverterFactory;
+
+import java.io.IOException;
+import java.time.Duration;
+import java.util.concurrent.TimeUnit;
+
+public class ErnieBotService {
+
+ private static final String BASE_URL = "https://aip.baidubce.com/";
+
+ private final ErnieBotApi api;
+
+ public ErnieBotService(ErnieBotApi api) {
+ this.api = api;
+ }
+
+
+ public static <T> T execute(Single<T> apiCall) {
+ try {
+ return apiCall.blockingGet();
+ } catch (HttpException var5) {
Review Comment:
avoiding variable name like var*
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -3056,6 +3059,23 @@ object KyuubiConf {
.stringConf
.createWithDefault("gpt-3.5-turbo")
+ val ERNIE_BOT_ACCESS_TOKEN: OptionalConfigEntry[String] =
+ buildConf("kyuubi.engine.chat.ernie.token")
+ .doc("The token to access ernie bot open API, which could be got at " +
+ "https://cloud.baidu.com/doc/WENXINWORKSHOP/s/Ilkkrb0i5")
+ .version("1.8.0")
+ .stringConf
+ .createOptional
+
+ val ERNIE_BOT_MODEL: ConfigEntry[String] =
+ buildConf("kyuubi.engine.chat.ernie.model")
+ .doc("ID of the model used in ernie bot. " +
+ "Available models are completions_pro, ernie_bot_8k, completions and eb-instant" +
+ "[Model overview](https://cloud.baidu.com/doc/WENXINWORKSHOP/s/6lp69is2a).")
+ .version("1.8.0")
Review Comment:
```suggestion
.version("1.9.0")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Kyuubi chat engine supports ernie bot(文心一言) [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5828:
URL: https://github.com/apache/kyuubi/pull/5828#discussion_r1418704806
##########
pom.xml:
##########
@@ -181,6 +181,7 @@
<mockito.version>4.11.0</mockito.version>
<netty.version>4.1.100.Final</netty.version>
<openai.java.version>0.12.0</openai.java.version>
+ <retrofit2.converter-jackson.version>2.9.0</retrofit2.converter-jackson.version>
Review Comment:
they shares the same version, let's use the main one
```suggestion
<retrofit2.version>2.9.0</retrofit2.converter-jackson.version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Kyuubi chat engine supports ernie bot(文心一言) [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5828:
URL: https://github.com/apache/kyuubi/pull/5828#discussion_r1418689370
##########
externals/kyuubi-chat-engine/src/main/scala/org/apache/kyuubi/engine/chat/ernie/service/ErnieBotService.java:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.engine.chat.ernie.service;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.PropertyNamingStrategy;
+import io.reactivex.Single;
+import okhttp3.ConnectionPool;
+import okhttp3.OkHttpClient;
+import org.apache.kyuubi.engine.chat.ernie.api.*;
+import org.apache.kyuubi.engine.chat.ernie.bean.ChatCompletionRequest;
+import org.apache.kyuubi.engine.chat.ernie.bean.ChatCompletionResult;
+import org.apache.kyuubi.engine.chat.ernie.constants.Model;
+import retrofit2.HttpException;
+import retrofit2.Retrofit;
+import retrofit2.adapter.rxjava2.RxJava2CallAdapterFactory;
+import retrofit2.converter.jackson.JacksonConverterFactory;
+
+import java.io.IOException;
+import java.time.Duration;
+import java.util.concurrent.TimeUnit;
+
+public class ErnieBotService {
+
+ private static final String BASE_URL = "https://aip.baidubce.com/";
+
+ private final ErnieBotApi api;
+
+ public ErnieBotService(ErnieBotApi api) {
+ this.api = api;
+ }
+
+
+ public static <T> T execute(Single<T> apiCall) {
+ try {
+ return apiCall.blockingGet();
+ } catch (HttpException var5) {
Review Comment:
avoid variable name like var*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [CHAT] Kyuubi chat engine supports ernie bot(文心一言) [kyuubi]
Posted by "zhaohehuhu (via GitHub)" <gi...@apache.org>.
zhaohehuhu commented on PR #5828:
URL: https://github.com/apache/kyuubi/pull/5828#issuecomment-1848837940
> Please update the config docs by running `dev/gen/gen_all_config_docs.sh`.
done. Thanks.
> Please update the config docs by running `dev/gen/gen_all_config_docs.sh`.
done. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [CHAT] Kyuubi chat engine supports ernie bot(文心一言) [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5828:
URL: https://github.com/apache/kyuubi/pull/5828#discussion_r1421868728
##########
externals/kyuubi-chat-engine/src/main/scala/org/apache/kyuubi/engine/chat/ernie/service/ErnieBotService.scala:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.engine.chat.ernie.service
+
+import java.io.IOException
+import java.time.Duration
+import java.util.concurrent.TimeUnit
+
+import com.fasterxml.jackson.annotation.JsonInclude
+import com.fasterxml.jackson.databind.{DeserializationFeature, ObjectMapper, PropertyNamingStrategy}
+import io.reactivex.Single
+import okhttp3.{ConnectionPool, OkHttpClient}
+import retrofit2.{HttpException, Retrofit}
+import retrofit2.adapter.rxjava2.RxJava2CallAdapterFactory
+import retrofit2.converter.jackson.JacksonConverterFactory
+
+import org.apache.kyuubi.engine.chat.api.{ApiHttpException, ErnieBotApi}
+import org.apache.kyuubi.engine.chat.ernie.bean.{ChatCompletionRequest, ChatCompletionResult}
+
+class ErnieBotService(api: ErnieBotApi) {
+
+ def execute[T](apiCall: Single[T]): T = {
+ try apiCall.blockingGet
+ catch {
+ case httpException: HttpException =>
+ try if (httpException.response != null && httpException.response.errorBody != null) {
+ val errorBody: String = httpException.response.errorBody.string
+ val statusCode: Int = httpException.response.code
+ throw new ApiHttpException(statusCode, errorBody, httpException)
+ } else {
+ throw httpException
+ }
+ catch {
+ case ioException: IOException =>
+ throw httpException
+ }
+ }
+ }
+
+ def createChatCompletion(
+ request: ChatCompletionRequest,
+ model: String,
+ accessToken: String): ChatCompletionResult = {
+ execute(
+ this.api
+ .createChatCompletion(model, accessToken, request))
Review Comment:
```suggestion
execute(this.api.createChatCompletion(model, accessToken, request))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [CHAT] Kyuubi chat engine supports ernie bot(文心一言) [kyuubi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5828:
URL: https://github.com/apache/kyuubi/pull/5828#issuecomment-1848848929
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5828?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `6 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`3677f3a`)](https://app.codecov.io/gh/apache/kyuubi/commit/3677f3a26e0088a95d80613ca380836585648f36?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.40% compared to head [(`0c4e010`)](https://app.codecov.io/gh/apache/kyuubi/pull/5828?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.43%.
> Report is 27 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/kyuubi/pull/5828?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://app.codecov.io/gh/apache/kyuubi/pull/5828?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | 77.77% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/kyuubi/pull/5828?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #5828 +/- ##
============================================
+ Coverage 61.40% 61.43% +0.02%
Complexity 23 23
============================================
Files 607 608 +1
Lines 35948 36121 +173
Branches 4939 4955 +16
============================================
+ Hits 22073 22190 +117
- Misses 11480 11536 +56
Partials 2395 2395
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kyuubi/pull/5828?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [CHAT] Kyuubi chat engine supports ernie bot(文心一言) [kyuubi]
Posted by "zhaohehuhu (via GitHub)" <gi...@apache.org>.
zhaohehuhu commented on code in PR #5828:
URL: https://github.com/apache/kyuubi/pull/5828#discussion_r1420658377
##########
pom.xml:
##########
@@ -181,6 +181,7 @@
<mockito.version>4.11.0</mockito.version>
<netty.version>4.1.100.Final</netty.version>
<openai.java.version>0.12.0</openai.java.version>
+ <retrofit2.converter-jackson.version>2.9.0</retrofit2.converter-jackson.version>
Review Comment:
Done. Plz help review again @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Kyuubi chat engine supports ernie bot [kyuubi]
Posted by "zhaohehuhu (via GitHub)" <gi...@apache.org>.
zhaohehuhu commented on PR #5828:
URL: https://github.com/apache/kyuubi/pull/5828#issuecomment-1844879588
@pan3793 plz help review this PR. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org