You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/06 18:46:50 UTC
[kudu-CR] [clock] clean up on chronyd test utility functions
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14378
Change subject: [clock] clean up on chronyd test utility functions
......................................................................
[clock] clean up on chronyd test utility functions
This patch contains a minor clean-up on StartChronydAtAutoReservedPort
utility function and its usages throughout various tests.
This patch does not contain any functional changes.
Change-Id: I71505e3ff686da638920bd1e9c99ef84bc511452
---
M src/kudu/clock/ntp-test.cc
M src/kudu/clock/test/mini_chronyd-test.cc
M src/kudu/clock/test/mini_chronyd_test_util.cc
M src/kudu/clock/test/mini_chronyd_test_util.h
4 files changed, 77 insertions(+), 70 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/14378/1
--
To view, visit http://gerrit.cloudera.org:8080/14378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I71505e3ff686da638920bd1e9c99ef84bc511452
Gerrit-Change-Number: 14378
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [clock] clean up on chronyd test utility functions
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14378 )
Change subject: [clock] clean up on chronyd test utility functions
......................................................................
Patch Set 1: Verified+1
Unrelated test failures:
* DiskFailure/DiskFailureITest.TestFailDuringServerStartup/0
--
To view, visit http://gerrit.cloudera.org:8080/14378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71505e3ff686da638920bd1e9c99ef84bc511452
Gerrit-Change-Number: 14378
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 07 Oct 2019 00:29:09 +0000
Gerrit-HasComments: No
[kudu-CR] [clock] clean up on chronyd test utility functions
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [clock] clean up on chronyd test utility functions
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I71505e3ff686da638920bd1e9c99ef84bc511452
Gerrit-Change-Number: 14378
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [clock] clean up on chronyd test utility functions
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14378 )
Change subject: [clock] clean up on chronyd test utility functions
......................................................................
[clock] clean up on chronyd test utility functions
This patch contains a minor clean-up on StartChronydAtAutoReservedPort
utility function and its usages throughout various tests.
This patch does not contain any functional changes.
Change-Id: I71505e3ff686da638920bd1e9c99ef84bc511452
Reviewed-on: http://gerrit.cloudera.org:8080/14378
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/clock/ntp-test.cc
M src/kudu/clock/test/mini_chronyd-test.cc
M src/kudu/clock/test/mini_chronyd_test_util.cc
M src/kudu/clock/test/mini_chronyd_test_util.h
4 files changed, 77 insertions(+), 70 deletions(-)
Approvals:
Alexey Serbin: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I71505e3ff686da638920bd1e9c99ef84bc511452
Gerrit-Change-Number: 14378
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [clock] clean up on chronyd test utility functions
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14378 )
Change subject: [clock] clean up on chronyd test utility functions
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71505e3ff686da638920bd1e9c99ef84bc511452
Gerrit-Change-Number: 14378
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 07 Oct 2019 04:24:41 +0000
Gerrit-HasComments: No