You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "adamkennedy (via GitHub)" <gi...@apache.org> on 2023/04/14 23:40:04 UTC

[GitHub] [calcite] adamkennedy opened a new pull request, #3152: CALCITE-5648 SqlDelegatingConformance incorrectly delegates to SqlConformanceEnum.DEFAULT

adamkennedy opened a new pull request, #3152:
URL: https://github.com/apache/calcite/pull/3152

   This PR makes SqlDelegatingConformance a true delegation class that delegates all methods (and will break in future if new methods are added and it isn't update). Fixed a type expectation in the test script, but otherwise did not change anything in the tests because none of the tests covered the methods changing in a way that was a mismatch for the DEFAULT value.
   
   With this change accidental oversights that fail to implement missing delegation methods cannot happen.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [calcite] libenchao closed pull request #3152: CALCITE-5648 SqlDelegatingConformance incorrectly delegates to SqlConformanceEnum.DEFAULT

Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao closed pull request #3152: CALCITE-5648 SqlDelegatingConformance incorrectly delegates to SqlConformanceEnum.DEFAULT
URL: https://github.com/apache/calcite/pull/3152


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org