You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/08 00:50:23 UTC
[GitHub] [flink] mattfysh opened a new pull request, #21254: Update docker.md
mattfysh opened a new pull request, #21254:
URL: https://github.com/apache/flink/pull/21254
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mattfysh commented on pull request #21254: Update docker.md
Posted by GitBox <gi...@apache.org>.
mattfysh commented on PR #21254:
URL: https://github.com/apache/flink/pull/21254#issuecomment-1317802478
> Flink also works without add, so why is it needed?
Did you test on v1.16?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mattfysh commented on pull request #21254: Update docker.md
Posted by GitBox <gi...@apache.org>.
mattfysh commented on PR #21254:
URL: https://github.com/apache/flink/pull/21254#issuecomment-1317799085
Hi @MartijnVisser - my apologies, I am short on time and hoped someone with PyFlink familiarity would pick this up and immediately identify why this change is required.
The current instructions do not work in Docker, which means they won't work on anyone's machine regardless of host setup
To reproduce, stand up a local cluster in session mode using the following steps:
1. Create a new folder
2. Create a Dockerfile inside the folder with the contents of "Using Flink Python on Docker": https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/deployment/resource-providers/standalone/docker/#using-flink-python-on-docker
3. Create a docker-compose.yaml file with the contents of "Session Mode": https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/deployment/resource-providers/standalone/docker/#session-cluster-yml
4. Change both instances of `image: flink:1.16.0-scala_2.12` to be `build: .`
5. Add a volumes entry to the `jobmanager` as:
volumes:
- .:/input
6. Create a word_count.py file with the contents of "The complete code so far" section https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/dev/python/table_api_tutorial/
7. Run `docker-compose up`
8. Enter the jobmanager via `docker exec -it [job_manager_container_id] bash`
9. Run `./bin/flink run --python /input/word_count.py`
This does not work, and throws the following error:
```
Caused by: java.lang.RuntimeException: Failed to create stage bundle factory! Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/fastavro/read.py", line 2, in <module>
from . import _read
File "fastavro/_read.pyx", line 11, in init fastavro._read
File "/usr/local/lib/python3.7/lzma.py", line 27, in <module>
from _lzma import *
ModuleNotFoundError: No module named '_lzma
```
This is occurring because when building Python from source, as instructed in the Flink documentation I have updated, certain "optional modules" in Python are not built if host dependencies could not be found. This includes things like readline, sqlite, etc, but also lzma - more information can be found at https://devguide.python.org/getting-started/setup-building/#unix particularly the "optional modules were not found" message
From what I gather, the latest version of PyFlink uses a version of fastavro that requires lzma to be present in the Python build. I assume the instructions I have updated used to work with older version of PyFlink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mattfysh commented on pull request #21254: Update docker.md
Posted by GitBox <gi...@apache.org>.
mattfysh commented on PR #21254:
URL: https://github.com/apache/flink/pull/21254#issuecomment-1347782454
Is there a desire within the Flink team to ensure that PyFlink achieves similar uptake and robustness as PySpark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21254: Update docker.md
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21254:
URL: https://github.com/apache/flink/pull/21254#issuecomment-1317672870
@mattfysh Thanks for the PR but please take the code contribution guide into account https://flink.apache.org/contributing/contribute-code.html
I can't see why it's important to add this; Flink also works without add, so why is it needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21254: Update docker.md
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21254:
URL: https://github.com/apache/flink/pull/21254#issuecomment-1359547294
> Is there a desire within the Flink team to ensure that PyFlink achieves similar uptake and robustness as PySpark?
I think any open source community strives to improve their product :)
Let me ping the maintainers on this PR once more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21254: Update docker.md
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21254:
URL: https://github.com/apache/flink/pull/21254#issuecomment-1306451186
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a11193c407491a278b0cfb53c48a1cf53c5ffbf1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a11193c407491a278b0cfb53c48a1cf53c5ffbf1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a11193c407491a278b0cfb53c48a1cf53c5ffbf1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21254: Update docker.md
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21254:
URL: https://github.com/apache/flink/pull/21254#issuecomment-1318771863
> Did you test on v1.16?
@dianfu @HuangXingBo I'm assuming we've done that, but you're the Python experts :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on pull request #21254: Update docker.md
Posted by GitBox <gi...@apache.org>.
dianfu commented on PR #21254:
URL: https://github.com/apache/flink/pull/21254#issuecomment-1360669458
Sorry for late response. I have missed this PR. The PR LGTM and I guess it should be caused by the bump of fastavro version which is introduced in https://issues.apache.org/jira/browse/FLINK-27058.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu closed pull request #21254: Update docker.md
Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #21254: Update docker.md
URL: https://github.com/apache/flink/pull/21254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org