[GitHub] [hbase] YutSean commented on a change in pull request #3498: HBASE-26094 L2 BC should not be the victimhandler of L1 BC when using combined BC

[GitBox <gi...@apache.org>]

YutSean commented on a change in pull request #3498:
URL: https://github.com/apache/hbase/pull/3498#discussion_r673620265



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
##########
@@ -77,8 +77,7 @@ public void cacheBlock(BlockCacheKey cacheKey, Cacheable buf) {
   @Override
   public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching,
       boolean repeat, boolean updateCacheMetrics) {
-    // TODO: is there a hole here, or just awkwardness since in the lruCache getBlock
-    // we end up calling l2Cache.getBlock.
+    // After HBASE-26094, in CombinedBC L2 cache is not the victim handler of L1.

Review comment:
       OK, will remove in the latest commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org