You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/04/12 12:34:51 UTC
Review Request 58387: Log Search common properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58387/
-----------------------------------------------------------
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Bugs: AMBARI-20742
https://issues.apache.org/jira/browse/AMBARI-20742
Repository: ambari
Description
-------
Allow specifying properties for both server and log feeder.
Diffs
-----
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-common-properties.xml PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py d00be4e
Diff: https://reviews.apache.org/r/58387/diff/1/
Testing
-------
Tested on local cluster.
Thanks,
Miklos Gergely
Re: Review Request 58387: Log Search common properties
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58387/
-----------------------------------------------------------
(Updated April 12, 2017, 2:17 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
Fix tests.
Bugs: AMBARI-20742
https://issues.apache.org/jira/browse/AMBARI-20742
Repository: ambari
Description
-------
Allow specifying properties for both server and log feeder.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-common-properties.xml PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 84a6ad9
ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 662e4a7
ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 52ac316
ambari-server/src/test/python/stacks/2.4/configs/default.json 8822e96
Diff: https://reviews.apache.org/r/58387/diff/2/
Changes: https://reviews.apache.org/r/58387/diff/1-2/
Testing
-------
Tested on local cluster.
Thanks,
Miklos Gergely
Re: Review Request 58387: Log Search common properties
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58387/#review171734
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On April 12, 2017, 12:34 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58387/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 12:34 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20742
> https://issues.apache.org/jira/browse/AMBARI-20742
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Allow specifying properties for both server and log feeder.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-common-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py d00be4e
>
>
> Diff: https://reviews.apache.org/r/58387/diff/1/
>
>
> Testing
> -------
>
> Tested on local cluster.
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 58387: Log Search common properties
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58387/#review171735
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On April 12, 2017, 12:34 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58387/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 12:34 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20742
> https://issues.apache.org/jira/browse/AMBARI-20742
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Allow specifying properties for both server and log feeder.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-common-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py d00be4e
>
>
> Diff: https://reviews.apache.org/r/58387/diff/1/
>
>
> Testing
> -------
>
> Tested on local cluster.
>
>
> Thanks,
>
> Miklos Gergely
>
>