You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by bo...@apache.org on 2007/11/20 09:49:46 UTC

svn commit: r596571 - /myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java

Author: bommel
Date: Tue Nov 20 00:49:46 2007
New Revision: 596571

URL: http://svn.apache.org/viewvc?rev=596571&view=rev
Log:
(TOBAGO-546) selectOneChoice should support coloring and images

Modified:
    myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java

Modified: myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java?rev=596571&r1=596570&r2=596571&view=diff
==============================================================================
--- myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java (original)
+++ myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java Tue Nov 20 00:49:46 2007
@@ -35,10 +35,11 @@
 import org.apache.myfaces.tobago.ajax.api.AjaxRenderer;
 import org.apache.myfaces.tobago.ajax.api.AjaxUtils;
 import org.apache.myfaces.tobago.component.ComponentUtil;
+import org.apache.myfaces.tobago.component.SupportsMarkup;
 import org.apache.myfaces.tobago.component.UIPage;
 import org.apache.myfaces.tobago.component.UIPanelBase;
-import org.apache.myfaces.tobago.component.UITabGroup;
 import org.apache.myfaces.tobago.component.UITab;
+import org.apache.myfaces.tobago.component.UITabGroup;
 import static org.apache.myfaces.tobago.component.UITabGroup.SWITCH_TYPE_CLIENT;
 import static org.apache.myfaces.tobago.component.UITabGroup.SWITCH_TYPE_RELOAD_PAGE;
 import static org.apache.myfaces.tobago.component.UITabGroup.SWITCH_TYPE_RELOAD_TAB;
@@ -61,9 +62,9 @@
 import javax.faces.context.FacesContext;
 import javax.faces.el.ValueBinding;
 import java.io.IOException;
+import java.util.Arrays;
 import java.util.List;
 import java.util.Map;
-import java.util.Arrays;
 
 public class TabGroupRenderer extends LayoutableRendererBase implements AjaxRenderer {
 
@@ -272,8 +273,8 @@
             outerClass.addClass("tab", "unselected-outer");
             innerClass.addClass("tab", "unselected-inner");
           }
-          outerClass.addMarkupClass(tab, "tab", "outer");
-          innerClass.addMarkupClass(tab, "tab", "outer");
+          outerClass.addMarkupClass((SupportsMarkup) tab, "tab", "outer");
+          innerClass.addMarkupClass((SupportsMarkup) tab, "tab", "outer");
           writer.startElement(HtmlConstants.TD, tab);
           writer.writeIdAttribute(tab.getClientId(facesContext));
           HtmlRendererUtil.renderTip(tab, writer);
@@ -352,7 +353,7 @@
     writer.startElement(HtmlConstants.TD, null);
     StyleClasses classes = new StyleClasses();
     classes.addClass("tab", "content");
-    classes.addMarkupClass(activeTab, "tab", "content");
+    classes.addMarkupClass((SupportsMarkup) activeTab, "tab", "content");
     writer.writeClassAttribute(classes);
     writer.writeStyleAttribute(bodyStyle);
     writer.flush();



Re: svn commit: r596571 - /myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java

Posted by Volker Weber <v....@inexso.de>.
> (TOBAGO-546) selectOneChoice should support coloring and images

why are changes to tabgrouprenderer related to TOBAGO-546?

2007/11/20, bommel@apache.org <bo...@apache.org>:
> Author: bommel
> Date: Tue Nov 20 00:49:46 2007
> New Revision: 596571
>
> URL: http://svn.apache.org/viewvc?rev=596571&view=rev
> Log:
> (TOBAGO-546) selectOneChoice should support coloring and images
>
> Modified:
>     myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java
>
> Modified: myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java
> URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java?rev=596571&r1=596570&r2=596571&view=diff
> ==============================================================================
> --- myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java (original)
> +++ myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java Tue Nov 20 00:49:46 2007
> @@ -35,10 +35,11 @@
>  import org.apache.myfaces.tobago.ajax.api.AjaxRenderer;
>  import org.apache.myfaces.tobago.ajax.api.AjaxUtils;
>  import org.apache.myfaces.tobago.component.ComponentUtil;
> +import org.apache.myfaces.tobago.component.SupportsMarkup;
>  import org.apache.myfaces.tobago.component.UIPage;
>  import org.apache.myfaces.tobago.component.UIPanelBase;
> -import org.apache.myfaces.tobago.component.UITabGroup;
>  import org.apache.myfaces.tobago.component.UITab;
> +import org.apache.myfaces.tobago.component.UITabGroup;
>  import static org.apache.myfaces.tobago.component.UITabGroup.SWITCH_TYPE_CLIENT;
>  import static org.apache.myfaces.tobago.component.UITabGroup.SWITCH_TYPE_RELOAD_PAGE;
>  import static org.apache.myfaces.tobago.component.UITabGroup.SWITCH_TYPE_RELOAD_TAB;
> @@ -61,9 +62,9 @@
>  import javax.faces.context.FacesContext;
>  import javax.faces.el.ValueBinding;
>  import java.io.IOException;
> +import java.util.Arrays;
>  import java.util.List;
>  import java.util.Map;
> -import java.util.Arrays;
>
>  public class TabGroupRenderer extends LayoutableRendererBase implements AjaxRenderer {
>
> @@ -272,8 +273,8 @@
>              outerClass.addClass("tab", "unselected-outer");
>              innerClass.addClass("tab", "unselected-inner");
>            }
> -          outerClass.addMarkupClass(tab, "tab", "outer");
> -          innerClass.addMarkupClass(tab, "tab", "outer");
> +          outerClass.addMarkupClass((SupportsMarkup) tab, "tab", "outer");
> +          innerClass.addMarkupClass((SupportsMarkup) tab, "tab", "outer");
>            writer.startElement(HtmlConstants.TD, tab);
>            writer.writeIdAttribute(tab.getClientId(facesContext));
>            HtmlRendererUtil.renderTip(tab, writer);
> @@ -352,7 +353,7 @@
>      writer.startElement(HtmlConstants.TD, null);
>      StyleClasses classes = new StyleClasses();
>      classes.addClass("tab", "content");
> -    classes.addMarkupClass(activeTab, "tab", "content");
> +    classes.addMarkupClass((SupportsMarkup) activeTab, "tab", "content");
>      writer.writeClassAttribute(classes);
>      writer.writeStyleAttribute(bodyStyle);
>      writer.flush();
>
>
>