You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "drccrd (via GitHub)" <gi...@apache.org> on 2026/08/25 12:52:44 UTC
[PR] kie-issues#3967: [drl-vscode-extension] drl vscode ext windows build [incubator-kie-tools]
drccrd opened a new pull request, #3968:
URL: https://github.com/apache/incubator-kie-tools/pull/3968
Closes #3967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-tools#3967: [drl-vscode-extension] drl vscode ext windows build [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #3968:
URL: https://github.com/apache/incubator-kie-tools/pull/3968#discussion_r3961292663
##########
scripts/bootstrap/link_packages_with_self.js:
##########
@@ -50,10 +50,10 @@ function selfLink(pkg, selfLinkPath) {
selfLinkPath
)} -> ${relTargetPath}`
);
- if (fs.existsSync(selfLinkPath)) {
+ if (fs.lstatSync(selfLinkPath, { throwIfNoEntry: false })) {
fs.unlinkSync(selfLinkPath);
}
- fs.symlinkSync(relTargetPath, selfLinkPath);
+ fs.symlinkSync(relTargetPath, selfLinkPath, process.platform === "win32" ? "junction" : undefined);
Review Comment:
I'm not against this change. Thanks @drccrd !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-tools#3967: [drl-vscode-extension] drl vscode ext windows build [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer merged PR #3968:
URL: https://github.com/apache/incubator-kie-tools/pull/3968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#3967: [drl-vscode-extension] drl vscode ext windows build [incubator-kie-tools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #3968:
URL: https://github.com/apache/incubator-kie-tools/pull/3968#discussion_r3853984459
##########
scripts/bootstrap/link_packages_with_self.js:
##########
@@ -50,10 +50,10 @@ function selfLink(pkg, selfLinkPath) {
selfLinkPath
)} -> ${relTargetPath}`
);
- if (fs.existsSync(selfLinkPath)) {
+ if (fs.lstatSync(selfLinkPath, { throwIfNoEntry: false })) {
fs.unlinkSync(selfLinkPath);
}
- fs.symlinkSync(relTargetPath, selfLinkPath);
+ fs.symlinkSync(relTargetPath, selfLinkPath, process.platform === "win32" ? "junction" : undefined);
Review Comment:
@tiagobento I checked the repo docs and there are various references to the support (or lack thereof) of native windows, but I didn't see anything specific to this point, and of course alternatives exist I could use (and have been using until now) - let me know if you would prefer this removed, then I will just keep the drl-vscode-extension changes in this branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#3967: [drl-vscode-extension] drl vscode ext windows build [incubator-kie-tools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #3968:
URL: https://github.com/apache/incubator-kie-tools/pull/3968#discussion_r3853984459
##########
scripts/bootstrap/link_packages_with_self.js:
##########
@@ -50,10 +50,10 @@ function selfLink(pkg, selfLinkPath) {
selfLinkPath
)} -> ${relTargetPath}`
);
- if (fs.existsSync(selfLinkPath)) {
+ if (fs.lstatSync(selfLinkPath, { throwIfNoEntry: false })) {
fs.unlinkSync(selfLinkPath);
}
- fs.symlinkSync(relTargetPath, selfLinkPath);
+ fs.symlinkSync(relTargetPath, selfLinkPath, process.platform === "win32" ? "junction" : undefined);
Review Comment:
@tiagobento I checked the repo docs and there are various references to the support of native windows, but I didn't see anything specific to this point, and of course alternatives exist I could use (and have been using until now) - let me know if you would prefer this removed, then I will just keep the drl-vscode-extension changes in this branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org