You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/29 16:42:42 UTC

[GitHub] [spark] Peng-Lei commented on a change in pull request #33573: [SPARK-36336][SQL] Add new exception of base exception used in QueryExecutionErrors

Peng-Lei commented on a change in pull request #33573:
URL: https://github.com/apache/spark/pull/33573#discussion_r679317946



##########
File path: core/src/main/scala/org/apache/spark/SparkException.scala
##########
@@ -41,6 +48,30 @@ class SparkException(
   override def getSqlState: String = SparkThrowableHelper.getSqlState(errorClass.orNull)
 }
 
+class SparkRuntimeException(
+    message: String,
+    cause: Throwable,

Review comment:
       ok,I will simplify this class to only accept errorClass and messageParameters,also with others. The cause is needed for it in QueryExecutionErrors. Thank you.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org