You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by gurisxie <gi...@git.apache.org> on 2017/10/19 03:57:20 UTC

[GitHub] incubator-weex pull request #810: * [ios] add jserror upload method, add tri...

GitHub user gurisxie opened a pull request:

    https://github.com/apache/incubator-weex/pull/810

    * [ios] add jserror upload method, add trigger positions on sdk init,…

    I need to add a method which used to upload jserror to it that has realized the protocol.
    
    it not sufficient before, I add it in some necessary address. 
    
    **if** *isBugFix* **:**
    
      * [ ] Make sure that you add at least one unit test for the bug which you had fixed.
    
    **elif** *isNewFeature* **:**
    
      * [ ] Update API docs for the component.
      * [ ] Update/Add demo to demonstrate new feature.
      * [ ] Update test scripts for the feature.
      * [ ] Add unit tests for the feature.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gurisxie/incubator-weex ios-feature-error-upload

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/810.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #810
    
----
commit e3b9c10ee99b3c6236f5e67867b634fd3377d7e6
Author: gurisxie <27...@qq.com>
Date:   2017-10-19T03:45:16Z

    * [ios] add jserror upload method, add trigger positions on sdk init,jsservice,jsbridge

----


---

[GitHub] incubator-weex pull request #810: * [ios] add jserror upload method, add tri...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/810


---

[GitHub] incubator-weex issue #810: * [ios] add jserror upload method, add trigger po...

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/810
  
    
    <!--
      0 failure: 
      0 warning: 
      2 messages
      
    -->
    
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>has no jsfm file changed.</td>
        </tr>
      
    <tr>
          <td>:book:</td>
          <td>jsfm test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---